Skip to content

Align comment visibility labels with Console #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruibaby merged 1 commit into from
Oct 14, 2026
Merged

Align comment visibility labels with Console #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/comment-widget/src/comment-management.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export class CommentManagement extends LitElement {
${this.target.spec.approved ? msg('Cancel approval') : msg('Approve')}
</button>
<button type="button" ?disabled=${this.busy} @click=${() => this.run(this.target?.spec.hidden ? 'unhide' : 'hide')}>
${this.target.spec.hidden ? msg('Unhide') : msg('Hide')}
${this.target.spec.hidden ? msg('Make public') : msg('Make private')}
</button>
<button type="button" class="text-red-500" ?disabled=${this.busy} @click=${() => this.run('delete')}>
${msg('Delete')}
Expand Down
4 changes: 2 additions & 2 deletions packages/comment-widget/src/generated/locales/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
's35c3125c7750681e': `Cita`,
's3643189d1abbb7f4': `Código`,
's3fb33d17bad61aa9': `Comentario enviado con éxito, pendiente de revisión`,
's424590dc43eddb44': `Hacer privado`,
's44851a8adf059eef': `Fijado`,
's4c0e15f9073382e6': `Error al obtener el código de verificación`,
's4d76c6944ffb0540': `No se pudo guardar. Es posible que el comentario se haya eliminado o que la versión actual de Halo no admita la edición. Tu borrador se ha conservado.`,
Expand All @@ -55,6 +56,7 @@
's64ef2a6c2dd1d3d1': `Editar`,
's67749057edb2586b': `Cerrar sesión`,
's6cb61eeccda272d5': `Bloque de código`,
's6df8f2a4e5b0fe18': `Hacer público`,
's6f23997fffbecc6a': `Cancelar aprobación`,
's7098f8d38ffe5e88': `Operación realizada correctamente`,
's7332f94a3fa137c3': `Tu comprobante de envío ha caducado. Comprueba si se envió tu comentario antes de continuar.`,
Expand All @@ -72,10 +74,8 @@
's8e176d64f6528d3d': str`El tamaño de la imagen no debe superar ${0} MiB.`,
's96668830629e0dfc': `Subir`,
's98a5f7789c49dd3f': `En revisión`,
's9df212d89cab196d': `Ocultar`,
's9f2ed66340f019c6': `Escribir un comentario`,
'sa10fbe3fcd6ae148': `Agregar respuesta`,
'sa3443b99ecf186ea': `Mostrar`,
'sa82fbb7f361c6f44': `Mostrar respuestas`,
'sa862e76e95967816': `Comentario actualizado correctamente`,
'sa8dddacbaa66f8e0': `Por favor, inicie sesión primero`,
Expand Down
4 changes: 2 additions & 2 deletions packages/comment-widget/src/generated/locales/zh-CN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
's35c3125c7750681e': `引用`,
's3643189d1abbb7f4': `代码`,
's3fb33d17bad61aa9': `评论成功，请等待审核`,
's424590dc43eddb44': `设为私密`,
's44851a8adf059eef': `置顶`,
's4c0e15f9073382e6': `获取验证码失败`,
's4d76c6944ffb0540': `保存失败。该评论可能已被删除，或当前 Halo 版本不支持编辑。你的草稿已保留。`,
Expand All @@ -55,6 +56,7 @@
's64ef2a6c2dd1d3d1': `编辑`,
's67749057edb2586b': `退出登录`,
's6cb61eeccda272d5': `代码块`,
's6df8f2a4e5b0fe18': `设为公开`,
's6f23997fffbecc6a': `取消通过`,
's7098f8d38ffe5e88': `操作成功`,
's7332f94a3fa137c3': `提交凭证已失效，请先核对评论是否已提交成功。`,
Expand All @@ -72,10 +74,8 @@
's8e176d64f6528d3d': str`单张图片大小不能超过 ${0} MiB。`,
's96668830629e0dfc': `上传`,
's98a5f7789c49dd3f': `审核中`,
's9df212d89cab196d': `隐藏`,
's9f2ed66340f019c6': `编写评论`,
'sa10fbe3fcd6ae148': `加入回复`,
'sa3443b99ecf186ea': `取消隐藏`,
'sa82fbb7f361c6f44': `显示回复`,
'sa862e76e95967816': `评论更新成功`,
'sa8dddacbaa66f8e0': `请先登录`,
Expand Down
4 changes: 2 additions & 2 deletions packages/comment-widget/src/generated/locales/zh-TW.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
's35c3125c7750681e': `引用`,
's3643189d1abbb7f4': `程式碼`,
's3fb33d17bad61aa9': `評論成功，請等待審核`,
's424590dc43eddb44': `設為私密`,
's44851a8adf059eef': `置頂`,
's4c0e15f9073382e6': `獲取驗證碼失敗`,
's4d76c6944ffb0540': `儲存失敗。該評論可能已被刪除，或目前 Halo 版本不支援編輯。你的草稿已保留。`,
Expand All @@ -55,6 +56,7 @@
's64ef2a6c2dd1d3d1': `編輯`,
's67749057edb2586b': `登出`,
's6cb61eeccda272d5': `程式碼區塊`,
's6df8f2a4e5b0fe18': `設為公開`,
's6f23997fffbecc6a': `取消通過`,
's7098f8d38ffe5e88': `操作成功`,
's7332f94a3fa137c3': `提交憑證已失效，請先核對評論是否已提交成功。`,
Expand All @@ -72,10 +74,8 @@
's8e176d64f6528d3d': str`單張圖片大小不能超過 ${0} MiB。`,
's96668830629e0dfc': `上傳`,
's98a5f7789c49dd3f': `審核中`,
's9df212d89cab196d': `隱藏`,
's9f2ed66340f019c6': `撰寫評論`,
'sa10fbe3fcd6ae148': `新增回覆`,
'sa3443b99ecf186ea': `取消隱藏`,
'sa82fbb7f361c6f44': `顯示回覆`,
'sa862e76e95967816': `評論更新成功`,
'sa8dddacbaa66f8e0': `請先登入`,
Expand Down
2 changes: 1 addition & 1 deletion packages/comment-widget/tests/comment-management.browser.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ test('Comment management regression checks', async () => {
.shadowRoot.querySelector('comment-management');
await management.updateComplete;
management.shadowRoot.querySelector('summary').click();
actionButton(management, 'Hide').click();
actionButton(management, 'Make private').click();
await until(() => item.comment.status.visibleReplyCount === 0);
assert(
comment.status.visibleReplyCount === 1,
Expand Down
16 changes: 8 additions & 8 deletions packages/comment-widget/xliff/es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,6 @@
<source>Approve</source>
<target>Aprobar</target>
</trans-unit>
<trans-unit id="sa3443b99ecf186ea">
<source>Unhide</source>
<target>Mostrar</target>
</trans-unit>
<trans-unit id="s9df212d89cab196d">
<source>Hide</source>
<target>Ocultar</target>
</trans-unit>
<trans-unit id="sdc673e73b5c13aea">
<source>Delete</source>
<target>Eliminar</target>
Expand Down Expand Up @@ -382,6 +374,14 @@
<source>Private replies are not publicly visible. Signed-in recipients can view them; anonymous recipients are notified by email when notifications are enabled.</source>
<target>Las respuestas privadas no son visibles públicamente. Los destinatarios que hayan iniciado sesión pueden verlas; los destinatarios anónimos reciben una notificación por correo electrónico si las notificaciones están habilitadas.</target>
</trans-unit>
<trans-unit id="s6df8f2a4e5b0fe18">
<source>Make public</source>
<target>Hacer público</target>
</trans-unit>
<trans-unit id="s424590dc43eddb44">
<source>Make private</source>
<target>Hacer privado</target>
</trans-unit>
</body>
</file>
</xliff>
16 changes: 8 additions & 8 deletions packages/comment-widget/xliff/zh-CN.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,6 @@
<source>Approve</source>
<target>审核通过</target>
</trans-unit>
<trans-unit id="sa3443b99ecf186ea">
<source>Unhide</source>
<target>取消隐藏</target>
</trans-unit>
<trans-unit id="s9df212d89cab196d">
<source>Hide</source>
<target>隐藏</target>
</trans-unit>
<trans-unit id="sdc673e73b5c13aea">
<source>Delete</source>
<target>删除</target>
Expand Down Expand Up @@ -382,6 +374,14 @@
<source>Private replies are not publicly visible. Signed-in recipients can view them; anonymous recipients are notified by email when notifications are enabled.</source>
<target>私密回复不会公开显示。已登录的被回复者可以查看；若启用了邮件通知，匿名被回复者会收到邮件通知。</target>
</trans-unit>
<trans-unit id="s6df8f2a4e5b0fe18">
<source>Make public</source>
<target>设为公开</target>
</trans-unit>
<trans-unit id="s424590dc43eddb44">
<source>Make private</source>
<target>设为私密</target>
</trans-unit>
</body>
</file>
</xliff>
16 changes: 8 additions & 8 deletions packages/comment-widget/xliff/zh-TW.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,6 @@
<source>Approve</source>
<target>審核通過</target>
</trans-unit>
<trans-unit id="sa3443b99ecf186ea">
<source>Unhide</source>
<target>取消隱藏</target>
</trans-unit>
<trans-unit id="s9df212d89cab196d">
<source>Hide</source>
<target>隱藏</target>
</trans-unit>
<trans-unit id="sdc673e73b5c13aea">
<source>Delete</source>
<target>刪除</target>
Expand Down Expand Up @@ -382,6 +374,14 @@
<source>Private replies are not publicly visible. Signed-in recipients can view them; anonymous recipients are notified by email when notifications are enabled.</source>
<target>私密回覆不會公開顯示。已登入的被回覆者可以查看；若已啟用電子郵件通知，匿名被回覆者會收到電子郵件通知。</target>
</trans-unit>
<trans-unit id="s6df8f2a4e5b0fe18">
<source>Make public</source>
<target>設為公開</target>
</trans-unit>
<trans-unit id="s424590dc43eddb44">
<source>Make private</source>
<target>設為私密</target>
</trans-unit>
</body>
</file>
</xliff>
Loading