Skip to content

test: deflake growing-file bounded-read test (HACK-1404) #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roodboi merged 1 commit into from
Oct 26, 2026
Merged

test: deflake growing-file bounded-read test (HACK-1404) #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/manage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3400,8 +3400,18 @@ describe("syncManagedTools", () => {
await Bun.write(join(home, "growth-stop"), "stop\n");

expect(result.codexInstall.status).toBe("failed");
expect(result.codexInstall.stderr).toContain("unexpected-growing");
expect(result.codexInstall.stderr).toContain("file changed");
// The mutator races the bounded reader. On a busy or single-core runner
// (seen on CI with Bun 1.4.4) the reader can finish between appends and
// then fails closed on the tree hash instead of the per-file change
// check. Both outcomes reject the payload; require one of them.
const stderr = result.codexInstall.stderr ?? "";
const caughtDuringRead =
stderr.includes("unexpected-growing") &&
(stderr.includes("file changed") || stderr.includes("file grew"));
const caughtByTreeHash = stderr.includes(
"installed tree hash differs from bundled payload"
);
expect(caughtDuringRead || caughtByTreeHash).toBe(true);
});

it("dry-runs bundled codex plugin setup without writing files", async () => {
Expand Down
Loading