Indexing payments management audit fix 2 light#1325

Open

RembrandtK wants to merge 37 commits intoindexing-payments-management-auditfrom

indexing-payments-management-audit-fix-2-light

Commits on Apr 20, 2026

docs: update audit extracts for PR1301 v02 report
RembrandtK
committed

Commits on Apr 27, 2026

fix(collector): add gas overhead buffer to callback prechecks (TRST-L-9)
RembrandtK
committed
fix(collector): cap returndata copy in payer callbacks (TRST-M-4)
RembrandtK
committed
docs: add response to TRST-L-10 EIP-7702 callback dispatch (won't fix)
RembrandtK
committed
feat(RAM): drop pair tracking below residual escrow threshold (TRST-M-1, TRST-M-5)
RembrandtK
committed
docs: add responses to TRST-L-6, TRST-R-7 (both won't fix)
RembrandtK
committed
docs(audit): acknowledge TRST-R-3 cancelAgreement defensive check
RembrandtK
committed
fix(collector): remove dead oldHash guard (TRST-R-6)
RembrandtK
committed
fix(collector): non-zero offer types, reserve OFFER_TYPE_NONE=0 sentinel (TRST-R-5)
RembrandtK
committed
refactor(interfaces): drop unused state and offer-option flags, tighten flag NatSpec (TRST-R-11)
RembrandtK
committed
docs(audit): acknowledge trust-boundary correction in TRST-H-4
RembrandtK
committed
docs(audit): acknowledge reclaim-reason change in TRST-R-13
RembrandtK
committed
docs(ram): document collector replay-protection assumption (TRST-R-4)
RembrandtK
committed
docs(ram): document non-retroactive role-change semantics (TRST-R-10)
RembrandtK
committed
docs(ram): align pause-escalation prose with whenNotPaused scope (TRST-R-8)
RembrandtK
committed
docs(collector): note self-authorization auth-check obligation (TRST-R-9)
RembrandtK
committed
fix(subgraph-service): validate update terms against RCAU rate, not stale agreement rate
RembrandtK
committed
refactor(collector): preparatory helpers, signatures, and version constants
RembrandtK
committed
refactor(collector): drop unreachable agreementId-zero check
RembrandtK
committed
refactor(collector): extract _requireValidTerms from duplicated validation
RembrandtK
committed
refactor(collector): split accept logic out of _validateAndStoreAgreement
RembrandtK
committed
refactor(collector): split update apply out of _validateAndStoreUpdate
RembrandtK
committed
feat(subgraph-service): idempotent accept/update with allocation rebinding
RembrandtK
committed
refactor(collector): hoist solhint-disable, idiomatic deadline comparisons
RembrandtK
committed
fix(collector): validate offer terms against deadline, not block.timestamp
RembrandtK
committed
refactor(collector): extract _getAgreementDetails/_versionHashAt helpers
RembrandtK
committed
fix(collector): persistent agreement.payer for independent cancellation (TRST-L-7)
RembrandtK
committed
feat(collector): idempotent accept/update/cancel-on-nothing
RembrandtK
committed
feat(collector): add OfferCancelled event for SCOPE_PENDING cancellations
RembrandtK
committed
feat(collector): per-version semantics in getAgreementDetails (TRST-L-11)
RembrandtK
committed
feat(collector): compose cancel/settled flags in getAgreementDetails (TRST-R-12)
RembrandtK
committed
feat(collector): add SCOPE_SIGNED to cancel() for EOA offer revocation (TRST-L-8)
RembrandtK
committed
feat(issuance): expose getIssuanceAllocator on IIssuanceTarget
RembrandtK
committed
fix(collector): validate full terms at offer time
RembrandtK
committed
fix(collector): respect deadlines in scoped claim cap
RembrandtK
committed
refactor(collector): collapse redundant state guard in _getMaxNextClaim
RembrandtK
committed
fix(collector): use dedicated error for invalid offer type in offer()
RembrandtK
committed