Skip to content

Add lint to ensure kKnownWGSLLanguageFeatures is complete #4701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kainino0x merged 2 commits into from
Sep 9, 2026
+29 −3
Merged

Add lint to ensure kKnownWGSLLanguageFeatures is complete #4701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6e1335
Add lint to ensure kKnownWGSLLanguageFeatures is complete
kainino0x Sep 9, 2026
ad6f6ad
Merge branch 'main' into requires
kainino0x Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions .eslintrc.json → .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,25 @@
{
/** List of WGSL language features for use in a lint check below. */
const kKnownWGSLLanguageFeatures = [
'readonly_and_readwrite_storage_textures',
'packed_4x8_integer_dot_product',
'unrestricted_pointer_parameters',
'pointer_composite_access',
'uniform_buffer_standard_layout',
'texture_and_sampler_let',
'subgroup_id',
'subgroup_uniformity',
'swizzle_assignment',
'linear_indexing',
'texture_formats_tier1',
'immediate_address_space',
'fragment_depth',
'buffer_view',
// IMPORTANT: Always add features to capability_info.ts before adding them here.
// This ensures that they're tested properly.
];
const kWGSLLanguageFeatureRegex = String.raw`requires\s+(?!(unknown|${kKnownWGSLLanguageFeatures.join('|')})\b)\w+\s*;`;

module.exports = {
"root": true,
"env": {
"browser": true,
Expand Down Expand Up @@ -63,7 +84,11 @@
"message": "Use hasFeature() instead of features.has().",
// features.has takes any string. We want only valid feature names.
"selector": "CallExpression[callee.property.name='has'][callee.object.name='features'],CallExpression[callee.property.name='has'][callee.object.property.name='features']"
}
},
{
"message": "Found WGSL `requires` directive with unknown token. Update `kKnownWGSLLanguageFeatures` in capability_info.ts, then in .eslintrc.cjs.",
"selector": `TemplateElement[value.cooked=/${kWGSLLanguageFeatureRegex}/], Literal[value=/${kWGSLLanguageFeatureRegex}/]`
},
],

// Plugin: gpuweb-cts
Expand Down Expand Up @@ -188,4 +213,4 @@
}
}
]
}
};
1 change: 1 addition & 0 deletions src/webgpu/capability_info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,6 +994,7 @@ export const kKnownWGSLLanguageFeatures = [
'immediate_address_space',
'fragment_depth',
'buffer_view',
// This list should be kept in sync with .eslintrc.cjs.
] as const;

export type WGSLLanguageFeature = (typeof kKnownWGSLLanguageFeatures)[number];
Loading