Add lint to ensure kKnownWGSLLanguageFeatures is complete - #4701
Merged
Conversation
Convert eslintrc from JSON to JS to make this easier to maintain.
dj2
approved these changes
Sep 9, 2026
kainino0x
enabled auto-merge (squash)
September 9, 2026 17:55
kainino0x
disabled auto-merge
September 9, 2026 17:55
kainino0x
enabled auto-merge (squash)
September 9, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to prevent tests from being written against WGSL language features without adding them to
kKnownWGSLLanguageFeaturesso that they will be tested by thewgsl_matches_apitest.It's not 100% foolproof, but should work pretty well. Best I think we can do without updating eslint and installing an extra dep to allow the eslint config to be written in TypeScript so it can import the same list that we use in the CTS.
Tested locally, the lint fails if I take any of the items out of the new list.
Issue: https://crbug.com/557328524
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.