Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/webgpu/api/validation/buffer/create.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ g.test('usage')
u
.combine('usage1', [0, ...kBufferUsages, kSomeBogusBufferUsage])
.combine('usage2', [0, ...kBufferUsages, kSomeBogusBufferUsage])
.filter(p => p.usage1 <= p.usage2)
.beginSubcases()
.combine('mappedAtCreation', [false, true])
)
Expand All @@ -83,6 +84,32 @@ g.test('usage')
);
});

g.test('new_usages')
.desc(`Valid usages not present in GPUBufferUsage shouldn't be accepted by createBuffer().`)
.params(u =>
u //
.beginSubcases()
.combine('usage', kBufferUsages)
)
.fn(t => {
const { usage } = t.params;

let exposedUsages = 0;
for (const v of Object.values(GPUBufferUsage)) {
exposedUsages |= v;
}

const success = (usage & exposedUsages) === usage;

t.expectGPUError(
'validation',
() => {
t.createBufferTracked({ size: 16, usage });
},
!success
);
});

const BufferUsage = GPUConst.BufferUsage;

g.test('createBuffer_invalid_and_oom')
Expand Down
29 changes: 29 additions & 0 deletions src/webgpu/api/validation/createTexture.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1132,6 +1132,35 @@ g.test('usage')
);
});

g.test('new_usages')
.desc(`Valid usages not present in GPUTextureUsage shouldn't be accepted by createTexture().`)
.params(u =>
u
.combine('usage', [
...kTextureUsages,
GPUConst.TextureUsage.RENDER_ATTACHMENT | GPUConst.TextureUsage.TRANSIENT_ATTACHMENT,
])
.filter(p => isValidTextureUsageCombination(p.usage))
)
.fn(t => {
const { usage } = t.params;

let exposedUsages = 0;
for (const v of Object.values(GPUTextureUsage)) {
exposedUsages |= v;
}

const success = (usage & exposedUsages) === usage;

t.expectGPUError(
'validation',
() => {
t.createTextureTracked({ format: 'rgba8unorm', size: [1, 1], usage });
},
!success
);
});

g.test('viewFormats')
.desc(
`Test creating a texture with viewFormats list for all {texture format}x{view format}. Only compatible view formats should be valid.`
Expand Down
Loading