Test that createBuffer/createTexture only allows exposed usages#4634
Open
kainino0x wants to merge 1 commit intogpuweb:mainfrom
Open
Test that createBuffer/createTexture only allows exposed usages#4634kainino0x wants to merge 1 commit intogpuweb:mainfrom
kainino0x wants to merge 1 commit intogpuweb:mainfrom
Conversation
|
Results for build job (at 9685122): -webgpu:api,validation,buffer,create:usage:* - 144 cases, 288 subcases (~2/case)
+webgpu:api,validation,buffer,create:usage:* - 78 cases, 156 subcases (~2/case)
+webgpu:api,validation,buffer,create:new_usages:* - 1 cases, 10 subcases (~10/case)
+webgpu:api,validation,createTexture:new_usages:* - 6 cases, 6 subcases (~1/case)
-TOTAL: 281182 cases, 2322747 subcases
+TOTAL: 281123 cases, 2322631 subcases |
For any buffer/texture usages known by the CTS, check that the browser only accepts it if it also exposes it. Currently the buffer test passes in all browsers - there haven't been any new usages in a long time. But next time we add a usage, this makes sure that when they start accepting the usage, they also start exposing it. The texture test fails in Safari because it's missing validation of unknown texture usages (this is also caught by another new test that tests an invalid usage). Passes in Chrome/Firefox. Unrelated cleanup: filter out redundant cases in createBuffer usage tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For any buffer/texture usages known by the CTS, check that the browser only accepts it if it also exposes it.
Currently the buffer test passes in all browsers - there haven't been any new usages in a long time. But next time we add a usage, this makes sure that when they start accepting the usage, they also start exposing it.
The texture test fails in Safari because it's missing validation of unknown texture usages (this is also caught by #4636 that tests an invalid usage). Passes in Chrome/Firefox.
Unrelated cleanup: filter out redundant cases in createBuffer usage tests.
Issue: none filed
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.