Skip to content

[DirectVerbs] Replace exp-verbs-related definitions in objs.hpp with gds_* definitions #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pakmarkthub wants to merge 23 commits into
base: devel-dv
Choose a base branch
from
Open

[DirectVerbs] Replace exp-verbs-related definitions in objs.hpp with gds_* definitions #101

pakmarkthub wants to merge 23 commits into from

Conversation

@pakmarkthub
Copy link
Contributor

@pakmarkthub pakmarkthub commented Sep 10, 2021

Prerequisite:

Problem:

  • Structs in objs.hpp are core components of libgdsync. However, many relies on exp-verbs.

This PR:

  • removes all definitions in objs.hpp related to exp-verbs.
  • replaces those definitions with new gds definitions.
  • the new gds definitions are compatible with the corresponding exp-verbs ones that they replace.

Presubmit testing:

  • compiled and ran successfully on Summit.

@pakmarkthub
Added --with-spectrum-mpi to configure
ce78eb6
@pakmarkthub
Introduced GDS_DRIVER_TYPE to gds_qp and gds_cq
66409ac
@pakmarkthub
Set gds_qp and gds_cq dtype to MLX5_EXP in the creation functions
fdd2270
@pakmarkthub
Changed the definition of gds_qp_init_attr_t and gds_send_wr. Also, r…
0073f81 
…emoved res_domain from the gds_qp struct
@pakmarkthub
Implemented gds_get_driver_type
78eadbb
@pakmarkthub
Initial implementation of mlx5-exp.cpp/hpp and moved create/destroy q…
aade2ab 
…p/cq functions to mlx5-exp
@pakmarkthub
Implemented gds_mlx5_exp_destroy_cq
5e789db
@pakmarkthub
Implemented gds_destroy_qp and gds_destroy_cq by connecting to gds_ml…
2a8ac7d 
…x5_exp_*
@pakmarkthub
Reimplemented gds_create_qp by connecting to gds_mlx5_exp_create_qp
a9351f2
@pakmarkthub
Moved gds_send_wr from exp-verbs to ib-verbs in gds_kernel_latency.c
e188668
@pakmarkthub
Fixed compile issues in gdsync.cpp and mlx5-exp.hpp
07d03a0
@pakmarkthub
Added mlx5-exp.cpp to the compile list
173841f
@pakmarkthub
Moved gds_prepare_send to gds_mlx5_exp_* and fixed compile errors in …
8d1ed50 
…mlx5-exp.*
@pakmarkthub
Modified gds_kernel_* applications to fit the new API/structs
10e164e
@pakmarkthub
Moved gds_wait_request to gds_mlx5_exp_wait_request and made the form…
b1cab05 
…er an opaque struct
@pakmarkthub
Moved gds_wait_request related functions to mlx5-exp
17b246f
@pakmarkthub
Changed the definition of gds_send_request_t
6be27ac
@pakmarkthub
Added gds_mlx5_exp_send_request_t definition and supported functions
f026578
@pakmarkthub
Moved APIs that use gds_send_request_t to mlx5-exp.cpp
92b09f0
@pakmarkthub
Removed include verbs_exp.h and peer_ops.h from public header files
e088b01
@pakmarkthub
Replaced structs related to ibv_exp_ with gds_* structs
942aa89
@pakmarkthub
Removed include verbs_exp.h and peer_ops.h from objs.hpp
35db866
@pakmarkthub
Removed include verbs_exp.h from objs.cpp
24a0a20
@pakmarkthub pakmarkthub mentioned this pull request Sep 10, 2021
Open
@pakmarkthub pakmarkthub changed the base branch from master to devel-dv September 10, 2021 05:59
@pakmarkthub pakmarkthub changed the title [DirectVerbs] Replaced exp-verbs-related definitions in objs.hpp with gds_* definitions [DirectVerbs] Replace exp-verbs-related definitions in objs.hpp with gds_* definitions Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drossetti drossetti Awaiting requested review from drossetti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pakmarkthub