build(deps): update AGP to 9.3.2, Gradle to 9.5.1, Places SDK to 5.3.0, and Compose BOM - #117
Conversation
Code Coverage
|
| alias(libs.plugins.ksp) | ||
| id("org.jetbrains.dokka") version "2.1.0" | ||
| alias(libs.plugins.ksp) apply false | ||
| alias(libs.plugins.dokka) apply false |
There was a problem hiding this comment.
Great work modernizing the build toolchain and dependencies. I found one small issue during my review, Please correct me if I am wrong. As per my investigation, we will face this issue after moving on Dokka 2.2.0
🚨 Blocking Issue: ./gradlew dokkaGenerate fails with Dokka 2.2.0
In build.gradle.kts, replacing id("org.jetbrains.dokka") version "2.1.0" with alias(libs.plugins.dokka) apply false switches the resolved Dokka version from 2.1.0 to 2.2.0 (dokka = "2.2.0" in libs.versions.toml).
Because this project currently uses android.builtInKotlin=false alongside com.android.library and org.jetbrains.kotlin.android, Dokka 2.2.0 registers both the androidJvm source set and the Android release source set pointing to src/main/java. Running ./gradlew dokkaGenerate (used by .github/workflows/docs.yml on release and Maven Javadoc JAR publishing) fails with:
Execution failed for task ':places-compose:dokkaGeneratePublicationHtml'
Pre-generation validity check failed: Source sets 'androidJvm' and 'release' have the common source roots... Every Kotlin source file should belong to only one source set (module).
Suggested Fix
Please add configureDokka() in build-logic/convention/src/main/kotlin/PublishingConventionPlugin.kt to suppress non-androidJvm duplicate source sets:
override fun apply(project: Project) {
project.run {
applyPlugins()
configureDokka()
configureJacoco()
configureVanniktechPublishing()
}
}
private fun Project.configureDokka() {
extensions.configure<org.jetbrains.dokka.gradle.DokkaExtension> {
dokkaSourceSets.configureEach {
suppress.set(name != "androidJvm")
}
}
}There was a problem hiding this comment.
Added configureDokka() to PublishingConventionPlugin.kt suppressing non-androidJvm source sets as suggested. Verified that ./gradlew dokkaGenerate now succeeds cleanly without issues. Thanks for catching this and providing the exact solution!
…0, and Compose BOM
752f1b4 to
5fbd63c
Compare
| appcompat = "1.7.1" | ||
| composeBom = "2026.04.01" | ||
| coreKtx = "1.18.0" | ||
| agp = "9.3.2" |
| appcompat = "1.7.1" | ||
| composeBom = "2026.04.01" | ||
| coreKtx = "1.18.0" | ||
| agp = "9.3.2" |
| appcompat = "1.7.1" | ||
| composeBom = "2026.04.01" | ||
| coreKtx = "1.18.0" | ||
| agp = "9.3.2" |
| coreKtx = "1.18.0" | ||
| agp = "9.3.2" | ||
| appcompat = "1.8.0" | ||
| composeBom = "2026.08.00" |
| ksp = "2.3.11" | ||
| lifecycleRuntimeKtx = "2.11.0" | ||
| lifecycleViewmodelCompose = "2.11.0" | ||
| mapsCompose = "8.5.0" |
| uiTestAndroid = "1.11.0" | ||
| uiToolingVersion = "1.11.0" | ||
| gradleMavenPublishPlugin = "0.36.0" | ||
| uiTestAndroid = "1.12.0" |
| uiToolingVersion = "1.11.0" | ||
| gradleMavenPublishPlugin = "0.36.0" | ||
| uiTestAndroid = "1.12.0" | ||
| uiToolingVersion = "1.12.0" |
| uiToolingVersion = "1.11.0" | ||
| gradleMavenPublishPlugin = "0.36.0" | ||
| uiTestAndroid = "1.12.0" | ||
| uiToolingVersion = "1.12.0" |
| uiToolingVersion = "1.11.0" | ||
| gradleMavenPublishPlugin = "0.36.0" | ||
| uiTestAndroid = "1.12.0" | ||
| uiToolingVersion = "1.12.0" |
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.1-bin.zip |
Description
This PR modernizes dependencies and build configurations for Android Places Compose:
All changes are fully validated against the 93.8% unit & Compose UI test suite established in PR #116.
📚 Stacked PR Chain
ci/workflow-security-hardening(Workflow permissions & action pinning)maintest/library-coverage-baseline(Test suite reaching 93.8% coverage)build/dependency-modernization(AGP 9.3.2, Gradle 9.5.1, Places 5.3.0)feat/places-usage-attribution(Usage attribution & remove:library)demo/ux-edge-to-edge-polish(Demo UX, edge-to-edge, mock location)Umbrella PR: #109