Skip to content

build(deps): update dependencies, edge-to-edge insets, and polish demo UX - #109

Open
dkhawk wants to merge 5 commits into
mainfrom
deps/auto-update
Open

build(deps): update dependencies, edge-to-edge insets, and polish demo UX#109
dkhawk wants to merge 5 commits into
mainfrom
deps/auto-update

Conversation

@dkhawk

@dkhawk dkhawk commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Note

Modular Review Stack Available:
For easier, atomic code reviews, the changes in this PR have been organized into a 5-part linear stack. Reviewers can review the individual PRs in sequence:

# PR Description Base Status
1 #115 ci/workflow-security-hardening (Workflow permissions & action pinning) main ✅ CI Passing
2 #116 test/library-coverage-baseline (Test suite reaching 93.8% coverage) #115 ✅ CI Passing
3 #117 build/dependency-modernization (AGP 9.3.2, Gradle 9.5.1, Places 5.3.0) #116 ✅ CI Passing
4 #119 feat/places-usage-attribution (Usage attribution & remove :library) #117 ✅ CI Passing
5 #118 demo/ux-edge-to-edge-polish (Demo UX, edge-to-edge, mock location) #119 ✅ CI Passing

Summary

  • Modernizes dependencies and build configurations (AGP 9.3.2, Kotlin 2.3.21, Gradle 9.5.1, Places SDK 5.3.0, Maps Compose 8.5.0, Maps Utils KTX 6.3.0, Compose BOM 2026.08.00).
  • Establishes a comprehensive unit & Compose UI test suite raising library coverage from 6.4% to 93.8%.
  • Hardens GitHub Actions workflows with explicit permissions, SHA pinning, and template injection prevention.
  • Implements usage attribution reporting via Places.addInternalUsageAttributionId and removes legacy orphaned :library module.
  • Refactors demo app with edge-to-edge system bars insets and Material 3 styling.
  • Adds mock location permission fallback option for rapid emulator testing.
  • Fixes editable text field state and virtual keyboard behavior in Landmark Selection form.
  • Adds regional Address Descriptor guidance banners, preset location jumps, loading feedback, and robust error handling for Geocoding.
  • Adds 'Save & Confirm Address' action and activity descriptions in MainActivity.

Testing

  • Verified on Android device: all activities function smoothly.
  • Comprehensive unit and Compose UI test suite passes with 93.8% library coverage.
  • All CI checks passing.

Comment thread gradle/libs.versions.toml Fixed
@googlemaps-bot

googlemaps-bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Code Coverage

Overall Project 86.47% -0.05% 🍏
Files changed 87.5% 🍏

File Coverage
AddressDto.kt 82.68% -0.65% 🍏

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.1-bin.zip
Comment thread places-compose-demo/src/main/res/values/strings.xml Fixed
Comment thread places-compose-demo/src/main/res/values/strings.xml Fixed
Comment thread places-compose-demo/src/main/res/values/strings.xml Fixed
@dkhawk dkhawk changed the title build(deps): update dependencies across android-places-compose build(deps): update dependencies, edge-to-edge insets, and polish demo UX Sep 1, 2026
@dkhawk
dkhawk requested a review from LoyalAbbas September 1, 2026 17:20
@dkhawk
dkhawk marked this pull request as ready for review September 1, 2026 18:37
@dkhawk
dkhawk requested a review from a team as a code owner September 1, 2026 18:37
Comment thread gradle/libs.versions.toml
appcompat = "1.7.1"
composeBom = "2026.04.01"
coreKtx = "1.18.0"
agp = "9.3.2"
Comment thread gradle/libs.versions.toml
appcompat = "1.7.1"
composeBom = "2026.04.01"
coreKtx = "1.18.0"
agp = "9.3.2"
Comment thread gradle/libs.versions.toml
appcompat = "1.7.1"
composeBom = "2026.04.01"
coreKtx = "1.18.0"
agp = "9.3.2"
@dkhawk
dkhawk marked this pull request as draft September 1, 2026 21:15
Comment thread gradle/libs.versions.toml
lifecycleRuntimeKtx = "2.11.0"
lifecycleViewmodelCompose = "2.11.0"
mapsCompose = "8.5.0"
mapsUtilsKtx = "6.3.0"
@dkhawk

dkhawk commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

This PR has been split into a 5-part review stack for easier, modular code review:

  1. ci: pin action SHAs, set permissions, and prevent template injection #115 (ci/workflow-security-hardening): GitHub Actions permissions, action SHA pinning, and template injection prevention.
  2. test: add comprehensive test suite for places-compose reaching 93.8% coverage #116 (test/library-coverage-baseline): Comprehensive unit and Compose UI test suite raising project coverage from 6.4% to 93.8%.
  3. build(deps): update AGP to 9.3.2, Gradle to 9.5.1, Places SDK to 5.3.0, and Compose BOM #117 (build/dependency-modernization): Dependency and build system modernization (AGP 9.3.2, Gradle 9.5.1, Compose BOM, Places SDK 5.3.0).
  4. feat(attribution): register usage attribution with Places SDK and remove legacy library module #119 (feat/places-usage-attribution): Usage attribution reporting with Places SDK and removal of legacy :library module.
  5. feat(demo): edge-to-edge insets, editable fields, mock location, and UX polish #118 (demo/ux-edge-to-edge-polish): Demo app edge-to-edge insets, editable form fields, mock location fallback, and UX polish.

Please review and merge the PRs in this stack in sequence starting with #115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants