Skip to content

feat(storage): support initial payload in bidi_write transport - #6489

Open
vsharonlynn wants to merge 2 commits into
googleapis:mainfrom
vsharonlynn:bidi-open-and-append-transport
Open

feat(storage): support initial payload in bidi_write transport#6489
vsharonlynn wants to merge 2 commits into
googleapis:mainfrom
vsharonlynn:bidi-open-and-append-transport

Conversation

@vsharonlynn

Copy link
Copy Markdown
Contributor

Issue #5716 .

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Aug 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to send an initial chunk of data when opening an appendable object in a bidirectional write stream, updating the connector, state, and transport layers to support and test this flow. The review feedback points out that the newly added public methods connect_open_and_append and new_open_and_append lack documentation, violating the repository style guide which requires all public items to be documented with ///.

Comment thread src/storage/src/storage/bidi_write/connector.rs
Comment thread src/storage/src/storage/bidi_write/transport.rs
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.93487% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.35%. Comparing base (c4c8d56) to head (711f73b).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/bidi_write/transport.rs 95.69% 4 Missing ⚠️
src/storage/src/storage/bidi_write/connector.rs 96.93% 3 Missing ⚠️
src/storage/src/storage/bidi_write/state.rs 98.57% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6489    +/-   ##
========================================
  Coverage   96.34%   96.35%            
========================================
  Files         295      295            
  Lines       83478    83677   +199     
========================================
+ Hits        80429    80626   +197     
- Misses       3049     3051     +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vsharonlynn
vsharonlynn marked this pull request as ready for review August 21, 2026 06:31
@vsharonlynn
vsharonlynn requested review from a team as code owners August 21, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant