Skip to content

feat(storage): expose send_and_append on OpenAppendableObject - #6490

Draft
vsharonlynn wants to merge 2 commits into
googleapis:mainfrom
vsharonlynn:bidi-open-and-append-api
Draft

feat(storage): expose send_and_append on OpenAppendableObject#6490
vsharonlynn wants to merge 2 commits into
googleapis:mainfrom
vsharonlynn:bidi-open-and-append-api

Conversation

@vsharonlynn

@vsharonlynn vsharonlynn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Issue #5716 .

This PR follows PR #6489 .

@vsharonlynn vsharonlynn changed the title Bidi open and append api feat(storage): expose send_and_append on OpenAppendableObject Aug 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to send an initial chunk of data when opening a bidirectional write stream for appendable objects. It adds a new send_and_append method to the OpenAppendableObject builder, updates the internal state machine (AppendObjectSpecState) and connector to handle and preserve the initial chunk (including CRC32C checksum calculation), and updates the transport layer to correctly initialize the write offset and running checksum. There are no review comments, and the implementation looks solid and well-tested.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.63526% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.28%. Comparing base (c4c8d56) to head (9afe3d7).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/transport.rs 0.00% 45 Missing ⚠️
src/storage/src/storage/stub.rs 0.00% 10 Missing ⚠️
src/storage/src/storage/bidi_write/transport.rs 95.69% 4 Missing ⚠️
src/storage/src/storage/open_appendable_object.rs 69.23% 4 Missing ⚠️
src/storage/src/storage/bidi_write/connector.rs 96.93% 3 Missing ⚠️
src/storage/src/storage/bidi_write/state.rs 98.57% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6490      +/-   ##
==========================================
- Coverage   96.34%   96.28%   -0.07%     
==========================================
  Files         295      295              
  Lines       83478    83745     +267     
==========================================
+ Hits        80429    80635     +206     
- Misses       3049     3110      +61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant