-
Notifications
You must be signed in to change notification settings - Fork 567
chore(storage): Update move logic now to support non-HNS buckets #32157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shubhangi-google
wants to merge
7
commits into
googleapis:main
Choose a base branch
from
shubhangi-google:refactor_move_object
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
714da03
remove references to hns from test cases
shubhangi-google a0ec97f
refactor
shubhangi-google 45199fc
refactor
shubhangi-google 5c4dff3
check permission
shubhangi-google 120d6c6
check
shubhangi-google bcffaf2
check
shubhangi-google e4e8df9
undo check
shubhangi-google File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubhangi-google AFAIK Move API is only supported for HNS buckets, for Non-HNS we will have to use copy + delete, correct me if I missed something. If not, could you add that and lets see if we still see move permission missing issue in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @cpriti-os this was the case earlier when move object API was supported by HNS bucekt only (#29391)
purpose of current PR is to provide support of move object- API to both HNS and NON HNS buckets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see this doc for permission reference https://cloud.google.com/storage/docs/json_api/v1/objects/move?apix_params=%7B%22bucket%22%3A%22ruby_8%22%2C%22sourceObject%22%3A%22cert.pdf%22%2C%22destinationObject%22%3A%22ruby_7%22%7D#required-permissions