chore(storage): Update move logic now to support non-HNS buckets #32157
Conversation
shubhangi-google
changed the title
shubhangi-google
changed the title
shubhangi-google
changed the title
shubhangi-google
changed the title
shubhangi-google
requested review from
a team and
yoshi-approver
as code owners
|
@shubhangi-google could you check why presubmits are failing. |
hi @cpriti-os I am not facing this error when I am running the samples with my user this seems to be a permission issue with the user used by kokoro |
shubhangi-google
dismissed stale reviews from viacheslav-rostovtsev and Pulkit0110
via
120d6c6
There was a problem hiding this comment.
@shubhangi-google AFAIK Move API is only supported for HNS buckets, for Non-HNS we will have to use copy + delete, correct me if I missed something. If not, could you add that and lets see if we still see move permission missing issue in this PR.
There was a problem hiding this comment.
hi @cpriti-os this was the case earlier when move object API was supported by HNS bucekt only (#29391)
purpose of current PR is to provide support of move object- API to both HNS and NON HNS buckets
There was a problem hiding this comment.
5 participants
This pull request broadens the utility of the
move_fileoperation within the Google Cloud Storage Ruby client library. By removing the prior limitation to Hierarchical Namespace (HNS) enabled buckets, themove_filemethod can now be used with any bucket type, making the storage client more versatile and user-friendly for file management tasks.Highlights
move_filefunctionality: Themove_fileoperation in the Google Cloud Storage client library now supports all bucket types, removing the previous restriction to only Hierarchical Namespace (HNS) enabled buckets.move_filemethod has been updated to reflect its broader applicability across all bucket types.move_filefunctionality on standard buckets, including tests for successful file movement and proper error handling when source and destination filenames are identical.