Skip to content

fix(bigquery-jdbc): ensure test uses unique dataset & cleans up #13587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logachev wants to merge 3 commits into
base: main
Choose a base branch
from
+26 −18
Open

fix(bigquery-jdbc): ensure test uses unique dataset & cleans up #13587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54ea75d
fix(bigquery-jdbc): ensure test uses unique dataset & cleans up
logachev Jun 30, 2026
5a495b0
feedback
logachev Jun 30, 2026
231e617
lint
logachev Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,10 @@ public class ITBase extends BigQueryJdbcBaseTest {
+ DDL_IT_CALLABLE_STMT_PROC_DML_DELETE_TEST
+ DDL_IT_CALLABLE_STMT_PROC_TEST;

public static String getUniqueDatasetName(String prefix) {
return prefix + System.currentTimeMillis() + "_" + (100 + new java.util.Random().nextInt(900));
}

public static synchronized String getSharedDataset() {
if (sharedDataset == null) {
sharedDataset =
Expand Down
40 changes: 22 additions & 18 deletions java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITBigQueryJDBCTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,30 +1743,34 @@ public void testValidDestinationTableSavesQueriesWithStandardSQL() throws SQLExc
public void testDestinationTableAndDestinationDatasetThatDoesNotExistsCreates()
throws SQLException {
// setup
String largeResultDataset = ITBase.getUniqueDatasetName("FakeDataset");
String connection_uri =
ITBigQueryJDBCTest.connection_uri
+ "QueryDialect=BIG_QUERY;"
+ "AllowLargeResults=1;"
+ "LargeResultTable=FakeTable;"
+ "LargeResultDataset=FakeDataset;";
String.format(
ITBigQueryJDBCTest.connection_uri
+ "QueryDialect=BIG_QUERY;"
+ "AllowLargeResults=1;"
+ "LargeResultTable=FakeTable;"
+ "LargeResultDataset=%s;",
largeResultDataset);
String selectLegacyQuery =
"SELECT * FROM [bigquery-public-data.deepmind_alphafold.metadata] LIMIT 200;";
Driver driver = BigQueryDriver.getRegisteredDriver();
Connection connection = driver.connect(connection_uri, new Properties());
Statement statement = connection.createStatement();

// act
ResultSet resultSet = statement.executeQuery(selectLegacyQuery);
try (Connection connection = driver.connect(connection_uri, new Properties())) {
Statement statement = connection.createStatement();

// assertion
assertNotNull(resultSet);
String separateQuery = "SELECT * FROM FakeDataset.FakeTable;";
boolean result = bigQueryStatement.execute(separateQuery);
assertTrue(result);
// act
ResultSet resultSet = statement.executeQuery(selectLegacyQuery);

// clean up
bigQueryStatement.execute("DROP SCHEMA FakeDataset CASCADE;");
connection.close();
// assertion
assertNotNull(resultSet);
String separateQuery = String.format("SELECT * FROM %s.FakeTable;", largeResultDataset);
boolean result = bigQueryStatement.execute(separateQuery);
assertTrue(result);
} finally {
// clean up
bigQueryStatement.execute(
String.format("DROP SCHEMA IF EXISTS %s CASCADE;", largeResultDataset));
}
}

@Test
Expand Down
Loading