fix(bigquery-jdbc): ensure test uses unique dataset & cleans up#13587
Open
logachev wants to merge 3 commits into
Open
fix(bigquery-jdbc): ensure test uses unique dataset & cleans up#13587logachev wants to merge 3 commits into
logachev wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a helper method getUniqueDatasetName to generate unique dataset names for integration tests and refactors testDestinationTableAndDestinationDatasetThatDoesNotExistsCreates to use this helper, wrap the connection in a try-with-resources block, and ensure cleanup occurs in a finally block. Feedback includes removing a redundant unary plus operator in the helper method and using DROP SCHEMA IF EXISTS in the cleanup block to avoid masking test failures if the dataset was never created.
Neenu1995
approved these changes
Jun 30, 2026
keshavdandeva
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testDestinationTableAndDestinationDatasetThatDoesNotExistsCreates was always using the same dataset. The moment this dataset was created in EU & likely failed to cleanup broke the test.