build: remove logic to normalize the repo-metadata values, keep original values instead#13586
build: remove logic to normalize the repo-metadata values, keep original values instead#13586sofisl wants to merge 3 commits into
Conversation
sofisl
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies transport handling by removing the conversion mapping in utilities.py and directly using the transport value. It also updates the README Jinja template to support rest and grpc+rest transport types, and updates the golden test metadata accordingly. The review feedback suggests using the in operator with a list of values in the Jinja template instead of multiple or conditions to make the code more concise and maintainable.
| {% elif metadata['repo']['transport'] == 'http' or metadata['repo']['transport'] == 'rest' -%} | ||
| {{metadata['repo']['name_pretty']}} uses HTTP/JSON for the transport layer. | ||
| {% elif metadata['repo']['transport'] == 'both' -%} | ||
| {% elif metadata['repo']['transport'] == 'both' or metadata['repo']['transport'] == 'grpc+rest' -%} | ||
| {{metadata['repo']['name_pretty']}} uses both gRPC and HTTP/JSON for the transport layer. |
There was a problem hiding this comment.
Using the in operator with a list of values is more concise and idiomatic in Jinja templates than multiple or conditions. This also makes it easier to maintain if more transport types are added in the future.
| {% elif metadata['repo']['transport'] == 'http' or metadata['repo']['transport'] == 'rest' -%} | |
| {{metadata['repo']['name_pretty']}} uses HTTP/JSON for the transport layer. | |
| {% elif metadata['repo']['transport'] == 'both' -%} | |
| {% elif metadata['repo']['transport'] == 'both' or metadata['repo']['transport'] == 'grpc+rest' -%} | |
| {{metadata['repo']['name_pretty']}} uses both gRPC and HTTP/JSON for the transport layer. | |
| {% elif metadata['repo']['transport'] in ['http', 'rest'] -%} | |
| {{metadata['repo']['name_pretty']}} uses HTTP/JSON for the transport layer. | |
| {% elif metadata['repo']['transport'] in ['both', 'grpc+rest'] -%} | |
| {{metadata['repo']['name_pretty']}} uses both gRPC and HTTP/JSON for the transport layer. |
…etadata (#6582) Remove the Java-specific mapping in RepoMetadataTransport that translated transport values to "http" or "both". Now it returns the standard values ("grpc", "rest", "grpc+rest") directly, aligning Java with other languages. After merging, we will merge googleapis/google-cloud-java#13586, once we update the librarian pseudo-version and regenerate the repo-metadata values. Fixes #4854
|
|
1 participant
This PR is an accompaniment to googleapis/librarian#6582. Opening this just so that it is clear to the PR reviewers what else will need to be done. However, before merging this PR, we should update the pseudo-version of librarian and regenerate all of the values after 6582 is merged.