Skip to content

fix: correct OAuth2 comment typo and remove duplicated funnel step #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avicennasis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct OAuth2 comment typo and remove duplicated funnel step #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-analytics-data/quickstart_oauth2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ async function main(propertyId = 'YOUR-GA4-PROPERTY-ID') {
}

/**
* Create a new OAuth2Client, and go through the OAuth2 content workflow.
* Create a new OAuth2Client, and go through the OAuth2 consent workflow.
* Return the full client to the callback.
*/
function getAuthenticatedClient() {
Expand Down
11 changes: 0 additions & 11 deletions google-analytics-data/run_funnel_report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,17 +105,6 @@ function main(propertyId = 'YOUR-GA4-PROPERTY-ID') {
},
},
},
{
name: 'Screen/Page view',
filterExpression: {
orGroup: {
expressions: [
{funnelEventFilter: {eventName: 'screen_view'}},
{funnelEventFilter: {eventName: 'page_view'}},
],
},
},
},
{
name: 'Purchase',
filterExpression: {
Expand Down
4 changes: 2 additions & 2 deletions google-analytics-data/run_report_with_dimension_and_metric_filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ function main(propertyId = 'YOUR-GA4-PROPERTY-ID') {

// Runs a report using both metric and dimension filters. A dimension filter
// limits the report to include only users who made an in-app purchase using
// Android platform. A metric filter specifies that only users with session
// counts larger than 1,000 should be included.
// the Android platform. A metric filter specifies that only users with
// session counts larger than 1,000 should be included.
async function runReportWithDimensionAndMetricFilters() {
const [response] = await analyticsDataClient.runReport({
property: `properties/${propertyId}`,
Expand Down
Loading