Repository navigation
fix: correct OAuth2 comment typo and remove duplicated funnel step - #34
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes in 3 files under
google-analytics-data/:quickstart_oauth2.js: "go through the OAuth2 content workflow" -> "OAuth2 consent workflow"run_report_with_dimension_and_metric_filters.js: "made an in-app purchase using Android platform" -> "using the Android platform" (comment re-wrapped to stay within 80 columns)run_funnel_report.js: the funnel definition listed theScreen/Page viewstep twice in a row, giving 6 steps. The comment above it, the default Funnel Exploration template it says it reproduces, and the Python version of this sample all have 5 steps. The duplicate step was removedBehaviour note: the
run_funnel_report.jschange alters the sample's request. The report now has 5 funnel steps instead of 6, with no repeatedScreen/Page viewstep.test/run_funnel_report.test.jsonly asserts onReport result, so it is unaffected.The other two changes touch comments only.