fix(runner): default InMemoryRunner appName to match Python SDK - #1485
Open
mithun-sudo wants to merge 1 commit into
Open
fix(runner): default InMemoryRunner appName to match Python SDK#1485mithun-sudo wants to merge 1 commit into
mithun-sudo wants to merge 1 commit into
Conversation
Contributor
|
Hi @mithun-sudo, thank you for your contribution and We appreciate you taking the time to submit this pull request. I have noticed that the maven build is failing with your changes, could you please address this? |
hemasekhar-p
added
the
waiting on reporter
Default the single-arg InMemoryRunner constructor to "InMemoryRunner" instead of agent.name(), aligning with adk-python.
mithun-sudo
force-pushed
the
fix/inmemory-runner-default-app-name
branch
from
September 8, 2026 13:57
405766a to
d4cafa4
Compare
Author
|
Fixed CI: spring-ai tests were still creating sessions with agent.name() while InMemoryRunner now defaults to "InMemoryRunner". Updated session creation to use runner.appName(). ./mvnw -Prelease clean package passes locally. |
Contributor
|
@mithun-sudo, thank you for addressing the comments. This PR is currently under review by our team and we will keep you posted if any further information is required. |
hemasekhar-p
added
needs review
and removed
waiting on reporter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1486
Summary
InMemoryRunner(BaseAgent)appName to"InMemoryRunner"instead ofagent.name(), matching adk-python.InMemoryRunnerTestand updateAgentWithMemoryTestto userunner.appName().Breaking change (minor)
Callers that relied on implicit
agent.name()as appName should usenew InMemoryRunner(agent, agent.name())explicitly.Test plan
./mvnw -pl core -am test— BUILD SUCCESS