Skip to content

InMemoryRunner default appName should be "InMemoryRunner" to match adk-python #1486

Description

@mithun-sudo

Description

InMemoryRunner(BaseAgent) currently defaults appName to agent.name().

In adk-python, the default is "InMemoryRunner" when no app_name is provided.

There is an explicit TODO in Java:
https://github.com/google/adk-java/blob/main/core/src/main/java/com/google/adk/runner/InMemoryRunner.java

Expected behavior

new InMemoryRunner(agent) should use appName = "InMemoryRunner".

Actual behavior

appName defaults to agent.name().

Impact

Callers using runAsync(userId, sessionId, ...) may fail to find sessions created under a different app name than the runner's implicit default.

Proposed fix

PR #1485

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions