Improve Filament Studio source builds#3252
Open
devshahofficial wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Improve Filament Studio source builds#3252devshahofficial wants to merge 1 commit intogoogle-deepmind:mainfrom
devshahofficial wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Contributor
Author
|
Keeping this PR focused on the Studio source-build path. I opened a separate stacked draft for the packaging/runtime follow-up pieces: generated Filament assets in install/wheels, default runtime asset lookup, and a small renderer identity query surfaced through Python. Follow-up draft: #3254 That follow-up is still draft because full wheel artifact verification is pending, but I smoke-tested Studio with a Go2 scene on macOS and verified the MJR-compat build exports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft improves the experimental Studio + Filament source-build path in two ways:
Motivation
While validating
mujoco_studiowithMUJOCO_USE_FILAMENT=ON, configure can fail on machines with ambient package-manager CMake configs, for example an Anaconda-providedabslConfig.cmake. Filament'sFILAMENT_USE_EXTERNAL_ABSLpath callsfind_package(absl), which can collide with the Abseil targets already created by MuJoCo's fetched dependency.This keeps the Filament fetch isolated from unrelated Abseil package configs, while preserving any pre-existing
CMAKE_DISABLE_FIND_PACKAGE_abslvalue after Filament is configured.Validation
git diff --check-DCMAKE_DISABLE_FIND_PACKAGE_absl=TRUEcmake --build build-studio-filament-eval --target mujoco_studio --parallel $(sysctl -n hw.logicalcpu)./mujoco_studio --gfx=opengl --model_file=/tmp/mujoco_go2_demo/unitree_go2/scene_filament_open_assets_showcase.xmlFEngine resolved backend: OpenGLScreenshot from the local smoke test:
Related context
Tagging a few people from the surrounding Filament/Studio discussion for visibility:
src/experimental/studio/: Renderer API #2487 (comment). This PR is a small source-build/doc cleanup around that path.Notes
The Go2 / Filament sample-asset scene used for the runtime smoke test is local-only and not included in this PR.