Set the USD schema multiccd scene flag default to True#3249
Open
LouRohanNV wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Set the USD schema multiccd scene flag default to True#3249LouRohanNV wants to merge 1 commit intogoogle-deepmind:mainfrom
LouRohanNV wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Contributor
Author
|
I believe the proper test for this new change is to add these lines in Also, I'm getting this from a review of the file: The assertion line that was deleted in the "enable multiccd" commit was already broken on its own terms: the macro compared a I'm not 100% certain if this is correct, but it suggests that these macros be adjusted to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multiccdwas enabled by default for 3.8.0, but the USD schema was not updated. Ideally there should be a test to detect this mismatch.