Handle rollout MuJoCo errors as warnings#3247
Open
devshahofficial wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Handle rollout MuJoCo errors as warnings#3247devshahofficial wants to merge 1 commit intogoogle-deepmind:mainfrom
devshahofficial wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Contributor
Author
|
@haroonq @yuvaltassa this is now marked ready for review. Would one of you, or another active maintainer/contributor, be able to take a look when you have bandwidth? Happy to follow up on any requested changes or adjust the approach if there is a better direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raise_on_errorto rollout so existing strict error behavior remains the defaultraise_on_error=False, intercept MuJoCo fatal errors during a rollout, fill the failed trajectory remainder from the current state and sensor data, and continue other batchesFixes #2704
Validation
python3 -m py_compile python/mujoco/rollout.py python/mujoco/rollout_test.pyMUJOCO_GL=disable /tmp/mujoco-rollout-venv/bin/python -m pytest -q --pyargs mujoco.rollout_test(67 passed, 1 skipped)