Repository navigation
security/tls: the translated heading keeps its English anchor - #37
Merged
Merged
Conversation
"When the certificate is asked for" was translated in fr, es and de
without {#when-the-certificate-is-asked-for}, so a link to that fragment
would land at the top of the page in three languages -- what the README's
rule (a translated heading keeps the English anchor as an explicit id) is
there to prevent. No link targets it today; the next one would have
failed silently.
Found by go-fleettools' new i18ncheck, which now reads this tree with 0
problems (with -comments: the configuration examples' comments are
translated on purpose). Hugo builds with --panicOnWarning; the anchor is in
the built fr, es and de pages.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heading "When the certificate is asked for" (
security/tls.md) was translated in fr, es and de without{#when-the-certificate-is-asked-for}. So a link to that fragment lands at the top of the page in three languages. That is exactly what the README's rule is there to prevent: a translated heading keeps the English anchor as an explicit id. No link targets it today; the next one would have failed silently.This adds the explicit id in the three languages, which takes one line each.
Found by go-fleettools' new
i18ncheck(go-fleettools/fleettools#73). With this change it reads the tree with 0 problems, using-comments, because the configuration examples' comments are translated on purpose. Hugo builds with--panicOnWarning, and the anchor is present in the built fr, es and de pages.🤖 Generated with Claude Code