Skip to content

ISLA S2400: remove the unused pitchFineCents local in the creator #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
git-moss merged 1 commit into from
Aug 22, 2026
Merged

ISLA S2400: remove the unused pitchFineCents local in the creator #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/de/mossgrabers/convertwithmoss/format/isla/s2400/S2400Creator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ private static void writeTrack (final ByteArrayOutputStream out, final int padIn
final boolean stereo = audioMetadata.getChannels () > 1;

final int gainDb = (int) Math.round (zone.getGain ());
final int pitchFineCents = (int) Math.round (zone.getTuning () * 100.0);
final int chokeGroup = Math.max (0, zone.getExclusiveGroup ());
final int gate = zone.isOneShot () ? 0 : 1;
final int mixdown = stereo ? S2400Constants.MIXDOWN_STEREO : S2400Constants.MIXDOWN_MONO_LR;
Expand Down Expand Up @@ -223,6 +222,7 @@ private static void writeTrack (final ByteArrayOutputStream out, final int padIn
private static void writeMainSlot (final ByteArrayOutputStream out, final ISampleZone zone, final int frames, final double durationSeconds)
{
final int end = Math.max (0, frames - 1);
final int pitchFineCents = (int) Math.round (zone.getTuning () * 100.0);

int filterMode = S2400Constants.FILTER_LOW_PASS;
int resonance = 0;
Expand All @@ -245,7 +245,7 @@ private static void writeMainSlot (final ByteArrayOutputStream out, final ISampl
writeU32Record (out, S2400Constants.FIELD_FILTER_MODE, filterMode);
writeU32Record (out, S2400Constants.FIELD_FILTER_RESONANCE, resonance);
writeU32Record (out, S2400Constants.FIELD_FILTER_CUTOFF, cutoffHertz);
writeI32Record (out, S2400Constants.FIELD_PITCH_FINE, (int) Math.round (zone.getTuning () * 100.0));
writeI32Record (out, S2400Constants.FIELD_PITCH_FINE, pitchFineCents);
writeU32Record (out, S2400Constants.FIELD_SLICE_START, 0);
writeU32Record (out, S2400Constants.FIELD_SLICE_END, end);
writeU32Record (out, S2400Constants.FIELD_RESERVED_34, 0);
Expand Down