ISLA S2400: remove the unused pitchFineCents local in the creator - #377
Open
douglas-carmichael wants to merge 1 commit into
Open
ISLA S2400: remove the unused pitchFineCents local in the creator#377douglas-carmichael wants to merge 1 commit into
douglas-carmichael wants to merge 1 commit into
Conversation
writeTrack computed pitchFineCents but never used it; writeMainSlot recomputed the same expression inline when writing FIELD_PITCH_FINE. Move the local to writeMainSlot and write it from there. The written kit is byte-identical. Fixes git-moss#376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeTrackcomputedpitchFineCentsbut never used it:writeMainSlotrecomputed the same expression inline when writingFIELD_PITCH_FINE, so the fine tune was already written correctly and the local was a leftover. This moves the local intowriteMainSlotand writes the field from it.Verified: a 2-zone SFZ with
tune=37/tune=-22converted to a kit with this branch and withmaingives byte-identical.kitand.wavfiles, and the kit converted back to SFZ returnstune=37/tune=-22.Fixes #376