feat(project-creation): Make alert frequency collapsible via ScmCollapsibleSection#117849
Draft
jaydgoss wants to merge 1 commit into
Draft
feat(project-creation): Make alert frequency collapsible via ScmCollapsibleSection#117849jaydgoss wants to merge 1 commit into
jaydgoss wants to merge 1 commit into
Conversation
This was referenced Jun 16, 2026
7c6a809 to
c20e5e2
Compare
acde609 to
7d94fd3
Compare
c20e5e2 to
b56d395
Compare
…psibleSection Apply ScmCollapsibleSection to the alert-frequency section in ScmProjectDetailsCore so it folds away in the project-creation flow (`collapsible = analyticsFlow === 'project-creation'`). Onboarding keeps the section always expanded. When collapsible, the chevron and title sit in the toggle and the "Get notified when things go wrong" subtitle moves into the collapsible body so it hides when collapsed. Onboarding renders the same header (bold label + subtitle) with the alert control always visible.
7d94fd3 to
370a8cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Applies
ScmCollapsibleSectionto the alert-frequency section ofScmProjectDetailsCore, folding it behind a toggle in the project-creation flow. Onboarding keeps the always-expanded header.Details
collapsible = analyticsFlow === 'project-creation', matching how the feature-selection section is gated.IconSirenheader, and the "Get notified when things go wrong" subtitle moves into the collapsible body so it hides when collapsed.IconSirenheader with an always-expanded body. The body markup is shared between both branches, so onboarding stays visually unchanged.ScmCollapsibleSectionbeyond the feature cards, exercising the reusable API (title+children).Stack
Draft: more changes coming on this branch.