Skip to content

feat(project-creation): Make alert frequency collapsible via ScmCollapsibleSection#117849

Draft
jaydgoss wants to merge 1 commit into
jaygoss/scm-collapsible-sectionfrom
jaygoss/scm-collapsible-alert-frequency
Draft

feat(project-creation): Make alert frequency collapsible via ScmCollapsibleSection#117849
jaydgoss wants to merge 1 commit into
jaygoss/scm-collapsible-sectionfrom
jaygoss/scm-collapsible-alert-frequency

Conversation

@jaydgoss

Copy link
Copy Markdown
Member

TLDR

Applies ScmCollapsibleSection to the alert-frequency section of ScmProjectDetailsCore, folding it behind a toggle in the project-creation flow. Onboarding keeps the always-expanded header.

Details

  • Gated with collapsible = analyticsFlow === 'project-creation', matching how the feature-selection section is gated.
  • The chevron and "Alert frequency" title replace the IconSiren header, and the "Get notified when things go wrong" subtitle moves into the collapsible body so it hides when collapsed.
  • Onboarding renders the original IconSiren header with an always-expanded body. The body markup is shared between both branches, so onboarding stays visually unchanged.
  • First reuse of ScmCollapsibleSection beyond the feature cards, exercising the reusable API (title + children).

Stack

  • #117731: SCM integration selector
  • #117846: Typography and copy polish
  • #117847: Reusable collapsible section (base of this PR)
  • PR 4 (this): Alert-frequency collapsible

Draft: more changes coming on this branch.

…psibleSection

Apply ScmCollapsibleSection to the alert-frequency section in
ScmProjectDetailsCore so it folds away in the project-creation flow
(`collapsible = analyticsFlow === 'project-creation'`). Onboarding keeps the
section always expanded.

When collapsible, the chevron and title sit in the toggle and the "Get
notified when things go wrong" subtitle moves into the collapsible body so it
hides when collapsed. Onboarding renders the same header (bold label +
subtitle) with the alert control always visible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant