feat(project-creation): Add reusable collapsible section for create flow#117847
Draft
jaydgoss wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
the
Scope: Frontend
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-section
branch
from
7c6a809 to
c20e5e2
Compare
jaydgoss
force-pushed
the
jaygoss/vdy-77-project-creation-ui-polish-and-analytics-pass
branch
from
59e9bd9 to
b5ae2bc
Compare
…apsibleSection
Introduce ScmCollapsibleSection, a reusable collapsible section for the SCM
project-creation flow, and use it to fold the "What do you want to
instrument?" feature cards. Enabled only in project creation (via
`collapsible={!isOnboarding}` from ScmPlatformFeaturesCore); the onboarding
flow keeps the cards always expanded with a plain heading.
ScmCollapsibleSection puts the chevron and title in one transparent toggle
button (mirroring the core Disclosure look) with an optional trailing slot
pinned right, and animates the body's own height (auto<->0) so sibling
layout="position" cards below follow via normal document flow.
initial=false keeps it from animating on mount. The body is indented to align
with the title copy.
It is a local variant of the core Disclosure rather than a consumer:
Disclosure.Content hides with display:none (can't tween, won't reflow the
sibling cards), and Disclosure.Title's full-width stretched button can't
express a content-hugging toggle without forking the shared component.
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-section
branch
from
c20e5e2 to
b56d395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Introduces
ScmCollapsibleSection, a reusable collapsible section for the SCM project-creation flow, and uses it to fold the "What do you want to instrument?" feature cards behind a toggle. Enabled in project creation only; the onboarding flow stays always-expanded.Details
ScmCollapsibleSectionputs the chevron and title in one transparent toggle button (mirroring the core Disclosure look) with an optional trailing slot pinned right. The body animates its own height (auto to 0) so siblinglayout="position"cards below reflow through normal document flow, andinitial={false}skips the mount animation so it renders in itsdefaultExpandedstate.Disclosure.Contenthides withdisplay: none, which cannot tween and would not reflow the sibling cards, andDisclosure.Title's full-width stretched button cannot express a content-hugging toggle without forking the shared component.ScmFeatureSelectionCardsviacollapsible={!isOnboarding}fromScmPlatformFeaturesCore. The component is built to be reused, with the alert-frequency section inscmProjectDetailsCoreas a likely next adopter.Stack
Draft: more changes coming on this branch.