Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sentry_sdk/scope.py
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,14 @@ def user(self, value: "Optional[Dict[str, Any]]") -> None:

def set_user(self, value: "Optional[Dict[str, Any]]") -> None:
"""Sets a user for the scope."""
self._user = value
if value is not None:
self._user = {}
for k, v in value.items():
if v is not None:
self._user[k] = v
else:
self._user = None

session = self.get_isolation_scope()._session
if session is not None:
session.update(user=value)
Expand Down
26 changes: 26 additions & 0 deletions tests/test_scope.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,32 @@ def test_scope_flags_copy():
]


def test_set_user(sentry_init, capture_events):
sentry_init()
events = capture_events()

sentry_sdk.get_isolation_scope().set_user({"id": "42", "email": "bob@example.com"})
capture_exception(NameError())
assert events[-1]["user"] == {"id": "42", "email": "bob@example.com"}

sentry_sdk.get_isolation_scope().set_user(None)
capture_exception(NameError())
assert "user" not in events[-1]


def test_set_user_none_values_are_dropped_when_copying_to_attributes(
sentry_init, capture_events
):
sentry_init()
events = capture_events()

sentry_sdk.get_isolation_scope().set_user(
{"email": "ada@beans.com", "username": None}
)
capture_exception(NameError())
assert events[-1]["user"] == {"email": "ada@beans.com"}


def test_merging(sentry_init, capture_events):
sentry_init()

Expand Down
Loading