fix(scope): Drop None user attribute values in set_user#6692
Open
ericapisani wants to merge 1 commit into
Open
fix(scope): Drop None user attribute values in set_user#6692ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
When set_user is called with a dict, any keys with None values are now filtered out before storing on the scope. This prevents None user attributes from being sent to Sentry.
Contributor
Codecov Results 📊✅ 89913 passed | ⏭️ 6297 skipped | Total: 96210 | Pass Rate: 93.45% | Execution Time: 310m 19s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2442 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.78% 89.75% -0.03%
==========================================
Files 192 192 —
Lines 23809 23814 +5
Branches 8218 8224 +6
==========================================
+ Hits 21375 21372 -3
- Misses 2434 2442 +8
- Partials 1346 1347 +1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_userpreviously stored None values verbatim in the user dict, which would send null attributes to Sentry. Now any key with a None value is filtered out before the dict is stored on the scope, so only meaningful user attributes are captured in events.Fixes PY-2567
Fixes #6689