Repository navigation
Conversation
…xy is set The extension now forwards envelopes through the proxy itself, so the SDK no longer falls back to sending directly when `http_proxy` is set. The SDK's own request to the extension skips the proxy via a new `proxy: false` transport option. The extension stays off when `transportOptions` sets a proxy or CA certificates, since it can't apply those. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 8ffdddf (PR test merge using develop at ab12f20) Against: 075093d (develop) · base run #66039
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 56 successful. See the run.
Successful checks
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 34d75e2. Configure here.
| expect.objectContaining({ | ||
| useLayerExtension: true, | ||
| tunnel: 'http://localhost:9000/envelope', | ||
| transportOptions: { keepAlive: false, proxy: false }, |
There was a problem hiding this comment.
Feat lacks integration coverage
Low Severity
This was flagged because the review guidelines ask feat PRs to include an integration or E2E test. The new path (leave the extension on when http_proxy is set, and skip the proxy for the tunnel with proxy: false) is only asserted in mocked unit tests, not in a real send through the extension.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 34d75e2. Configure here.
…tp_proxy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lambda layer users with
http_proxyset now send events through the Lambda extension by default, instead of the SDK falling back to sending directly. The extension stays off whentransportOptionssetsproxyorcaCerts.makeNodeTransportgets aproxy: falseoption that ignores proxy env vars.Why
With #26359 the extension applies the proxy itself, so disabling it whenever
http_proxyis set is no longer needed. The SDK's own request tolocalhost:9000must skip the proxy;proxy: falsedoes that only for the extension tunnel, instead of exempting loopback for every Node user.transportOptions.proxy/caCertskeep the old path because the extension only reads env vars and would drop them. This changes the default delivery path for proxied layer users; they can opt out withuseLayerExtension: falseorSENTRY_LAYER_EXTENSION=false.