Repository navigation
Conversation
The Lambda extension forwarded envelopes with a plain `fetch`, which ignores `http_proxy`/`https_proxy`, so functions in a VPC without direct internet access lost events. It now uses the same proxy agent and `no_proxy` handling as the Node transport. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: ab12f20 (PR test merge using develop at c7d73e4) Against: c7d73e4 (develop) · base run #66026 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 45 successful. See the run.
Successful checks
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4486655. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Lambda extension now sends envelopes to Sentry through
http_proxy/https_proxyand respectsno_proxy, picking the proxy the same way the Node transport does.Why
The extension forwarded envelopes with a plain
fetch, which ignores proxy env vars, so functions that can only reach the internet through a proxy lost events once they enabled the extension. The proxy logic moves into a sharedgetProxyAgentin@sentry/node(exported as_INTERNAL_getProxyAgent) so both paths behave identically. This grows the extension bundle from ~5.8 KB to ~10.5 KB for the vendored proxy agent. Only lowercase env vars are read, matching the SDK transport. #26360, stacked on top, turns the extension on by default when a proxy is set.Closes: #17902