Repository navigation
Conversation
…e entry Worker apps can now use the same handleError as Node apps instead of calling captureException in their own handler. The function only uses @sentry/core, which the Cloudflare entry already imports. The Cloudflare entry of the react-router-8-framework e2e app uses it now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 879c591 (PR test merge using develop at c9e61e3) Against: c9e61e3 (develop) · base run #65906 ✅ Baseline matches: this diff contains only this PR's changes.
|
JPeer264
marked this pull request as ready for review
November 13, 2026 07:03
javascript-sdk-gitflow
Bot
requested review from
chargome,
nicohrubec and
s1gr1d
November 13, 2026 07:03
JPeer264
requested review from
andreiborza and
isaacs
and removed request for
chargome and
s1gr1d
November 13, 2026 07:03
Contributor
Optional E2E testsAll optional checks were successful. 1 successful. See the run. Successful checks
|
nicohrubec
approved these changes
Nov 13, 2026
chargome
approved these changes
Nov 13, 2026
mydea
added a commit
that referenced
this pull request
Nov 13, 2026
**Why:** The sub-teams' "Only notify requested team members" setting (managed in security-as-code) only stops the team-wide notification if a team member is *already* requested when the team request lands. GitHub requests the CODEOWNERS teams the moment a PR is opened or marked ready. `assign-reviewers` requests individuals about 10s later. That's too late, so the whole sub-team still gets pinged. In #26343, for example, `team-javascript-sdks-framework` was requested at 07:03:05 and the workflow's picks at 07:03:15. No ruleset requires code owner review (`require_code_owner_review: false` on develop, master, v7 and v8/9/10). CODEOWNERS only routes reviewers, and the workflow does that now. So the same rules move to `.github/REVIEWERS`, which GitHub ignores and only the workflow reads. The sub-teams stop getting team requests, and the workflow keeps picking 3 people from them. The develop ruleset still requests `team-javascript-sdks` on every PR. getsentry/security-as-code#3923 turns on auto-assignment of 1 member for that team, so GitHub requests a person together with the team and the whole team isn't notified. GitHub can pick a manager there, and Terraform can't exclude members from auto-assignment. So pending review requests from `NEVER_REQUEST` users don't count towards the 3, and the workflow still requests 3 other people. A PR can end up with 4 requested reviewers. **How to review:** The rename plus the two path changes (the rules didn't change), then the `NEVER_REQUEST` filter in `scripts/assign-reviewers.mjs`. **Unsure about:** - We lose GitHub's "owned by" badge in the file view and the code owner shortcut in the reviewer picker. - Reviews that managers have already submitted still count towards the 3. Only pending requests are skipped. - GitHub's pick isn't filtered for the requester of a Junior PR the way the workflow's picks are. - `pull_request_target` runs the base branch's workflow, so this PR still routes reviewers from the old path until it merges. - Merge together with getsentry/security-as-code#3923. <!-- junior-request-attribution:start --> via @mydea. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AD0CA8FXFXAS%3A1794557278.893269 --> -- [View Session](https://junior-prod.sentry.dev/conversations/slack%3AD0CA8FXFXAS%3A1794557278.893269) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AD0CA8FXFXAS%3A1794557278.893269/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exports
createSentryHandleErrorfrom@sentry/react-router/cloudflare, so a Worker uses the samehandleErroras a Node server:The Cloudflare entry of the
react-router-8-frameworke2e app uses it now, so the server error tests cover it on Cloudflare.Why
Until now, Worker apps had to write their own
handleErrorthat callscaptureException. The function only uses@sentry/core, which the Cloudflare entry already imports. The React Router Cloudflare quick start in getsentry/sentry-docs#20724 can use it after the release.