Repository navigation
chore(ci): Move reviewer routing out of CODEOWNERS - #26346
Merged
Merged
Conversation
GitHub requests every matching code owner team when a PR opens, before the assign-reviewers workflow requests individuals, so the team-level 'only notify requested team members' setting never kicks in and the whole team gets pinged. Keep the same rules in .github/REVIEWERS, which only the workflow reads. Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
Contributor
size-limit report 📦Compared: c2ffcd9 (PR test merge using develop at 73e928a) Against: 73e928a (develop) · base run #65941 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 55 successful. See the run.
Successful checks
|
team-javascript-sdks will auto-assign one reviewer so GitHub doesn't ping the whole team. GitHub can pick a manager, so the workflow removes pending review requests from NEVER_REQUEST users and doesn't count them, which makes it pick someone else instead. Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 817898e. Configure here.
Instead of removing a manager that GitHub's auto-assignment picked, leave the request in place and top up to 3 other reviewers, so a PR can end up with 4. Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
isaacs
approved these changes
Nov 13, 2026
JPeer264
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The sub-teams' "Only notify requested team members" setting (managed in security-as-code) only stops the team-wide notification if a team member is already requested when the team request lands. GitHub requests the CODEOWNERS teams the moment a PR is opened or marked ready.
assign-reviewersrequests individuals about 10s later. That's too late, so the whole sub-team still gets pinged. In #26343, for example,team-javascript-sdks-frameworkwas requested at 07:03:05 and the workflow's picks at 07:03:15.No ruleset requires code owner review (
require_code_owner_review: falseon develop, master, v7 and v8/9/10). CODEOWNERS only routes reviewers, and the workflow does that now. So the same rules move to.github/REVIEWERS, which GitHub ignores and only the workflow reads. The sub-teams stop getting team requests, and the workflow keeps picking 3 people from them.The develop ruleset still requests
team-javascript-sdkson every PR. getsentry/security-as-code#3923 turns on auto-assignment of 1 member for that team, so GitHub requests a person together with the team and the whole team isn't notified. GitHub can pick a manager there, and Terraform can't exclude members from auto-assignment. So pending review requests fromNEVER_REQUESTusers don't count towards the 3, and the workflow still requests 3 other people. A PR can end up with 4 requested reviewers.How to review: The rename plus the two path changes (the rules didn't change), then the
NEVER_REQUESTfilter inscripts/assign-reviewers.mjs.Unsure about:
pull_request_targetruns the base branch's workflow, so this PR still routes reviewers from the old path until it merges.via @mydea.
--
View Session [Sentry]