Skip to content

feat(core): Add sentry.timestamp.sequence attribute for timestamp tie-breaking #19421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
logaretm wants to merge 10 commits into
base: develop
Choose a base branch
from
+432 −26
Draft

feat(core): Add sentry.timestamp.sequence attribute for timestamp tie-breaking #19421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0af425c
feat: add tie-breaking attribute to generated logs
logaretm Feb 19, 2026
bd3f97f
feat(core): Align sequence attribute with spec and add to metrics
logaretm Mar 6, 2026
ffa2dc9
refactor(core): Rename sequence util to timestampSequence
logaretm Mar 6, 2026
1bd3da3
chore: reformat
logaretm Mar 6, 2026
edfee19
chore: Bump size limits for affected bundles
logaretm Mar 6, 2026
05f3d2f
fix: lint
logaretm Mar 6, 2026
8ba57b4
fix: Add sentry.timestamp.sequence attribute to test assertions
logaretm Mar 6, 2026
1cc231b
feat(core): Skip sending sentry.timestamp.sequence when value is 0
logaretm Mar 6, 2026
7b0ae80
revert: Remove skip-sequence-0 optimization, keep always sending attr…
logaretm Mar 6, 2026
ac732f7
fix: Add sentry.timestamp.sequence to node integration logger test
logaretm Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .size-limit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/prod/index.js',
import: createImport('init', 'logger'),
gzip: true,
limit: '27 KB',
limit: '28 KB',
},
{
name: '@sentry/browser (incl. Metrics & Logs)',
Expand Down Expand Up @@ -255,21 +255,21 @@ module.exports = [
path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
gzip: false,
brotli: false,
limit: '131 KB',
limit: '132 KB',
},
{
name: 'CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed',
path: createCDNPath('bundle.replay.logs.metrics.min.js'),
gzip: false,
brotli: false,
limit: '209 KB',
limit: '210 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Replay) - uncompressed',
path: createCDNPath('bundle.tracing.replay.min.js'),
gzip: false,
brotli: false,
limit: '245 KB',
limit: '246 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed',
Expand Down
15 changes: 15 additions & 0 deletions dev-packages/browser-integration-tests/suites/public-api/logger/integration/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'console.trace {} {}', type: 'string' },
'sentry.message.parameter.0': { value: 123, type: 'integer' },
'sentry.message.parameter.1': { value: false, type: 'boolean' },
Expand All @@ -49,6 +50,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'console.debug {} {}', type: 'string' },
'sentry.message.parameter.0': { value: 123, type: 'integer' },
'sentry.message.parameter.1': { value: false, type: 'boolean' },
Expand All @@ -64,6 +66,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'console.log {} {}', type: 'string' },
'sentry.message.parameter.0': { value: 123, type: 'integer' },
'sentry.message.parameter.1': { value: false, type: 'boolean' },
Expand All @@ -79,6 +82,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'console.info {} {}', type: 'string' },
'sentry.message.parameter.0': { value: 123, type: 'integer' },
'sentry.message.parameter.1': { value: false, type: 'boolean' },
Expand All @@ -94,6 +98,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'console.warn {} {}', type: 'string' },
'sentry.message.parameter.0': { value: 123, type: 'integer' },
'sentry.message.parameter.1': { value: false, type: 'boolean' },
Expand All @@ -109,6 +114,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'console.error {} {}', type: 'string' },
'sentry.message.parameter.0': { value: 123, type: 'integer' },
'sentry.message.parameter.1': { value: false, type: 'boolean' },
Expand All @@ -124,6 +130,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -136,6 +143,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'Object: {}', type: 'string' },
'sentry.message.parameter.0': { value: '{"key":"value","nested":{"prop":123}}', type: 'string' },
},
Expand All @@ -150,6 +158,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'Array: {}', type: 'string' },
'sentry.message.parameter.0': { value: '[1,2,3,"string"]', type: 'string' },
},
Expand All @@ -164,6 +173,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'Mixed: {} {} {} {}', type: 'string' },
'sentry.message.parameter.0': { value: 'prefix', type: 'string' },
'sentry.message.parameter.1': { value: '{"obj":true}', type: 'string' },
Expand All @@ -181,6 +191,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -193,6 +204,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -205,6 +217,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -217,6 +230,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'first {} {} {}', type: 'string' },
'sentry.message.parameter.0': { value: 0, type: 'integer' },
'sentry.message.parameter.1': { value: 1, type: 'integer' },
Expand All @@ -233,6 +247,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
'sentry.origin': { value: 'auto.log.console', type: 'string' },
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'hello {} {} {}', type: 'string' },
'sentry.message.parameter.0': { value: true, type: 'boolean' },
'sentry.message.parameter.1': { value: 'null', type: 'string' },
Expand Down
5 changes: 5 additions & 0 deletions dev-packages/browser-integration-tests/suites/public-api/logger/scopeAttributes/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
log_attr: { value: 'log_attr_1', type: 'string' },
},
},
Expand All @@ -44,6 +45,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
global_scope_attr: { value: true, type: 'boolean' },
log_attr: { value: 'log_attr_2', type: 'string' },
},
Expand All @@ -57,6 +59,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
global_scope_attr: { value: true, type: 'boolean' },
isolation_scope_1_attr: { value: 100, unit: 'millisecond', type: 'integer' },
log_attr: { value: 'log_attr_3', type: 'string' },
Expand All @@ -71,6 +74,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
global_scope_attr: { value: true, type: 'boolean' },
isolation_scope_1_attr: { value: 100, unit: 'millisecond', type: 'integer' },
scope_attr: { value: 200, unit: 'millisecond', type: 'integer' },
Expand All @@ -86,6 +90,7 @@ sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
global_scope_attr: { value: true, type: 'boolean' },
isolation_scope_1_attr: { value: 100, unit: 'millisecond', type: 'integer' },
scope_2_attr: { value: 300, unit: 'millisecond', type: 'integer' },
Expand Down
12 changes: 12 additions & 0 deletions dev-packages/browser-integration-tests/suites/public-api/logger/simple/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -44,6 +45,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -55,6 +57,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -66,6 +69,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -77,6 +81,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -88,6 +93,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
},
},
{
Expand All @@ -99,6 +105,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
'sentry.message.parameter.0': { value: 'trace', type: 'string' },
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
Expand All @@ -115,6 +122,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
'sentry.message.parameter.0': { value: 'debug', type: 'string' },
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
Expand All @@ -131,6 +139,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
'sentry.message.parameter.0': { value: 'info', type: 'string' },
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
Expand All @@ -147,6 +156,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
'sentry.message.parameter.0': { value: 'warn', type: 'string' },
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
Expand All @@ -163,6 +173,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
'sentry.message.parameter.0': { value: 'error', type: 'string' },
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
Expand All @@ -179,6 +190,7 @@ sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page
attributes: {
'sentry.sdk.name': { value: 'sentry.javascript.browser', type: 'string' },
'sentry.sdk.version': { value: expect.any(String), type: 'string' },
'sentry.timestamp.sequence': { value: expect.any(Number), type: 'integer' },
'sentry.message.template': { value: 'test %s %s %s %s', type: 'string' },
'sentry.message.parameter.0': { value: 'fatal', type: 'string' },
'sentry.message.parameter.1': { value: 'stringArg', type: 'string' },
Expand Down
Loading
Loading