feat(core): Add sentry.timestamp.sequence attribute for timestamp tie-breaking#19421
Draft
feat(core): Add sentry.timestamp.sequence attribute for timestamp tie-breaking#19421
sentry.timestamp.sequence attribute for timestamp tie-breaking#19421Conversation
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
5 tasks
Rename `sentry.log.sequence` to `sentry.timestamp.sequence` per the published spec. Extract sequence logic into a shared utility so both logs and metrics use a single counter, enabling cross-telemetry ordering. The counter resets to 0 when the integer millisecond timestamp changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
logaretm
changed the title
sentry.timestamp.sequence attribute for timestamp tie-breaking
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sequence 0 is the default and doesn't provide tie-breaking value, so omitting it saves bytes on the vast majority of telemetry items. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
logaretm
force-pushed
the
awad/js-1762-add-log-sequence-attribute-for-timestamp-tie-breaking
branch
from
2471999 to
1cc231b
Compare
…ibute Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
sentry.timestamp.sequenceattribute for both logs and metrics, following the logs spec v1.16.0 and metrics spec.The attribute provides deterministic ordering of telemetry items that share the same millisecond timestamp.
A single shared counter is used across all telemetry types so logs and metrics can be ordered relative to each other. The counter starts at
0, increments by1per item, and resets when the integer millisecond timestamp changes.Closes #19420