Repository navigation
feat(github): Keep drafts that would ping code owners or break AGENTS.md - #3380
Open
sentry-junior[bot] wants to merge 3 commits into
Open
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: Burak Yigit Kaya <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 200c382. Configure here.
Co-Authored-By: Burak Yigit Kaya <126780+BYK@users.noreply.github.com>
Contributor
|
247 screenshot changes — 0 changed · 247 added · 0 removed |
sentry-junior
Bot
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: since #3250, Junior marks its draft ready once the required checks pass. Two problems: marking a draft ready makes GitHub ask the CODEOWNERS owners to review, so teammates get pinged before the requester has looked. And a repo's
AGENTS.mdcan say PRs stay drafts (sentry-javascript: "Always open PRs as draft"), which the auto-ready ignored. Replaces #3350.What:
github_getPullRequestnow returns:code_owners: owners of the changed files, read from the base branch's CODEOWNERS file (.github/, the root, thendocs/). It's matched deterministically with theignorepackage, since CODEOWNERS uses gitignore patterns. The last matching rule wins, and a rule with no owners clears them. If a CODEOWNERS file exists but GitHub doesn't list the changed files, the call fails so the draft stays a draft.agents_md: the rootAGENTS.mdof the base branch.code_ownersis empty andAGENTS.mddoesn't ask for drafts. Otherwise it stays a draft, and Junior tells the requester in the thread that the checks pass and it's waiting for their review, with the reason.github-code: in a repo with a CODEOWNERS file, open a draft unless the requester asks for a ready PR.Known gap: GitHub matches
docs/*only to files directly indocs/, but gitignore also matches files deeper down. So this can list too many owners, never too few.via @BYK.
--
View Session [Sentry]