Repository navigation
feat(github): Keep drafts that a person marks ready - #3350
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
requested changes
Nov 13, 2026
BYK
left a comment
BYK
left a comment
Member
There was a problem hiding this comment.
blocking since we can do a more flexible approach
Contributor
Author
|
Superseded by #3380. Instead of a per-PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: since #3250, the Watch of a Junior draft marks it ready when the required checks pass. That also happens to drafts that are drafts on purpose. getsentry/sentry-javascript's
AGENTS.mdsays "Always open PRs as draft" so the requester can review first. Junior opened getsentry/sentry-javascript#26352 as a draft for that reason, then marked it ready 4 minutes later and requested reviews. Reported by @JPeer264.Fix:
github_createPullRequestgets an optionalkeep_draft. Junior sets it on a draft when the repo's instructions or the requester ask for a draft, or say that a person marks it ready. That draft's Watch does not getpull_request.checks.recovered, so Junior never wakes up to mark it ready. Failed checks, reviews, and the review request onready_for_reviewwork as before. Drafts withoutkeep_draftkeep the #3250 behavior.The choice is made when the PR is created, while the repo's
AGENTS.mdis in context. A rule in the checks-passed guidance would depend on the later turn still seeing it.Limits: no eval covers the
keep_draftchoice, because no behavioral eval creates a PR end to end yet. The unit test covers only the Watch shape.via @mydea.
--
View Session [Sentry]