Skip to content

fix: attatchments not downloaded #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrinoff wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: attatchments not downloaded #1699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3c6c63
fix: attatchments not downloaded
andrinoff Jul 24, 2026
f1bed29
chore: lint
andrinoff Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2346,7 +2346,15 @@ func (m *mainModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { //nolint:gocyclo
Encoding: encoding,
Mailbox: msg.Mailbox,
}
return m, tea.Batch(m.current.Init(), downloadAttachmentCmd(account, email.UID, newMsg))
// Resolve the actual IMAP folder the email lives in, mirroring the body
// fetch path. Custom folders (Starred, All Mail, Important) report
// Mailbox == MailboxInbox but carry the real name via folderInbox, so
// without this the attachment is fetched from INBOX and fails.
folderName := folderInbox
if m.folderInbox != nil {
folderName = m.folderInbox.GetCurrentFolder()
}
return m, tea.Batch(m.current.Init(), downloadAttachmentCmd(account, email.UID, folderName, newMsg))

case tui.AttachmentDownloadedMsg:
var statusMsg string
Expand Down Expand Up @@ -3603,7 +3611,7 @@ func truncateUTF8(s string, maxBytes int) string {
return s
}

func downloadAttachmentCmd(account *config.Account, uid uint32, msg tui.DownloadAttachmentMsg) tea.Cmd {
func downloadAttachmentCmd(account *config.Account, uid uint32, folderName string, msg tui.DownloadAttachmentMsg) tea.Cmd {
return func() tea.Msg {
// Download and decode the attachment using encoding provided in msg.Encoding.
var data []byte
Expand All @@ -3616,7 +3624,15 @@ func downloadAttachmentCmd(account *config.Account, uid uint32, msg tui.Download
case tui.MailboxArchive:
data, err = fetcher.FetchArchiveAttachment(account, uid, msg.PartID, msg.Encoding)
case tui.MailboxInbox:
data, err = fetcher.FetchAttachment(account, uid, msg.PartID, msg.Encoding)
fallthrough
default:
// MailboxInbox and any custom folder (Starred, All Mail, Important, ...).
// Select the exact folder the email lives in rather than assuming INBOX.
if folderName != "" {
data, err = fetcher.FetchAttachmentFromMailbox(account, folderName, uid, msg.PartID, msg.Encoding)
} else {
data, err = fetcher.FetchAttachment(account, uid, msg.PartID, msg.Encoding)
}
}

if err != nil {
Expand Down