Skip to content

fix: attatchments not downloaded#1699

Open
andrinoff wants to merge 2 commits into
floatpane:masterfrom
andrinoff:fix/attachments-not-downloaded
Open

fix: attatchments not downloaded#1699
andrinoff wants to merge 2 commits into
floatpane:masterfrom
andrinoff:fix/attachments-not-downloaded

Conversation

@andrinoff

Copy link
Copy Markdown
Member

What?

Fetches the actual IMAP folder name for attachment downloads

Why?

Fixes #1689

Signed-off-by: drew <me@andrinoff.com>
@andrinoff
andrinoff requested a review from a team as a code owner July 24, 2026 12:30
@floatpanebot floatpanebot added bug Something isn't working size/S Diff: 11–50 lines labels Jul 24, 2026
@andrinoff

Copy link
Copy Markdown
Member Author

/build

@floatpanebot

floatpanebot commented Jul 24, 2026

Copy link
Copy Markdown
Member

Benchmark report — no significant change

Metrics worse: 0 · better: 0 (threshold: ±3%).

benchstat output
goos: linux
goarch: amd64
pkg: github.com/floatpane/matcha/backend
cpu: AMD EPYC 9V74 80-Core Processor                
                           │    old.txt    │               new.txt               │
                           │    sec/op     │    sec/op      vs base              │
ParseSearchQuery_Simple-4    2.779µ ± 264%   3.056µ ±  34%       ~ (p=0.485 n=6)
ParseSearchQuery_Complex-4   7.442µ ±  30%   7.382µ ± 154%       ~ (p=0.937 n=6)
TokenizeSearchQuery-4        4.158µ ±  30%   4.978µ ± 210%       ~ (p=0.093 n=6)
geomean                      4.414µ          4.824µ         +9.30%

                           │  old.txt   │              new.txt               │
                           │    B/op    │    B/op     vs base                │
ParseSearchQuery_Simple-4    26.00 ± 0%   26.00 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   762.0 ± 0%   762.0 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        176.0 ± 0%   176.0 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      151.6        151.6       +0.00%
¹ all samples are equal

                           │  old.txt   │              new.txt               │
                           │ allocs/op  │ allocs/op   vs base                │
ParseSearchQuery_Simple-4    2.000 ± 0%   2.000 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   23.00 ± 0%   23.00 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        9.000 ± 0%   9.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      7.453        7.453       +0.00%
¹ all samples are equal

pkg: github.com/floatpane/matcha/tui
                    │   old.txt    │               new.txt                │
                    │    sec/op    │    sec/op      vs base               │
LogPanelView-4        175.8µ ±  8%    178.1µ ± 10%        ~ (p=0.699 n=6)
SearchOverlayView-4   205.5µ ± 11%    182.4µ ± 11%  -11.23% (p=0.041 n=6)
InboxConstruction-4   943.3µ ± 12%   1071.3µ ± 19%        ~ (p=0.093 n=6)
geomean               324.2µ          326.5µ         +0.72%

                    │    old.txt    │               new.txt               │
                    │     B/op      │     B/op       vs base              │
LogPanelView-4        44.67Ki ± 51%   44.67Ki ± 51%       ~ (p=1.000 n=6)
SearchOverlayView-4   56.14Ki ± 41%   56.14Ki ± 41%       ~ (p=0.801 n=6)
InboxConstruction-4   874.2Ki ±  0%   874.3Ki ±  0%       ~ (p=0.394 n=6)
geomean               129.9Ki         129.9Ki        +0.01%

                    │   old.txt   │              new.txt              │
                    │  allocs/op  │  allocs/op   vs base              │
LogPanelView-4         714.0 ± 0%    714.0 ± 0%       ~ (p=1.000 n=6)
SearchOverlayView-4    926.0 ± 0%    926.0 ± 0%       ~ (p=1.000 n=6)
InboxConstruction-4   3.477k ± 0%   3.478k ± 0%       ~ (p=0.141 n=6)
geomean               1.320k        1.320k       +0.01%

auto-generated by benchmarks.yml

Signed-off-by: drew <me@andrinoff.com>
@floatpanebot

Copy link
Copy Markdown
Member

Build complete (e3c6c63)

Warning

This is an unreviewed PR build and has not been security audited. It may contain bugs, vulnerabilities, or malicious code. Do not use for daily use. Only use for testing purposes.

OS Arch Download
Linux amd64 matcha_preview_linux_amd64.tar.gz
Linux arm64 matcha_preview_linux_arm64.tar.gz
macOS amd64 matcha_preview_darwin_amd64.tar.gz
macOS arm64 matcha_preview_darwin_arm64.tar.gz
Windows amd64 matcha_preview_windows_amd64.zip
Windows arm64 matcha_preview_windows_arm64.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size/S Diff: 11–50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Failed to fetch attachment from different mailbox folder via gmail. [AI Disclosure]

2 participants