Skip to content

build_image_util: symlink user patches into dest - #4372

Merged
t-lo merged 1 commit into
mainfrom
t-lo/build_image-symlink-user-patches
Nov 9, 2026
Merged

t-lo merged 1 commit into
mainfrom
t-lo/build_image-symlink-user-patches

Conversation

@t-lo

@t-lo t-lo commented Nov 9, 2026

Copy link
Copy Markdown
Member

This change symlinks our user patches into the image install destination. It fixes an issue with portage when installing binpkgs which breaks the image build:

!!! The following binary packages have been ignored due to user patches:
       net-misc/wget-1.25.0-r3 for /home/sdk/trunk/src/build/images/arm64-usr/developer-9999.0.6104+github-4348-a1/dev-image-rootfs/
...
!!! All binary packages that could satisfy "net-misc/wget" for /home/sdk/trunk/src/build/images/arm64-usr/developer-9999.0.6104+github-4348-a1/dev-image-rootfs/ have been masked.

This change symlinks our user patches into the image install
destination. It fixes an issue with portage when installing binpkgs
which breaks the image build:

!!! The following binary packages have been ignored due to user patches:
       net-misc/wget-1.25.0-r3 for /home/sdk/trunk/src/build/images/arm64-usr/developer-9999.0.6104+github-4348-a1/dev-image-rootfs/
...
!!! All binary packages that could satisfy "net-misc/wget" for /home/sdk/trunk/src/build/images/arm64-usr/developer-9999.0.6104+github-4348-a1/dev-image-rootfs/ have been masked.

Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
@t-lo
t-lo requested a review from a team as a code owner November 9, 2026 12:07
Copilot AI balanced review requested due to automatic review settings November 9, 2026 12:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the change linking board user patches into the image build’s Portage configuration root.

No open issues 🎉

What changed in this PR

Makes board user patches available to Portage during image creation, addressing binary packages being rejected because of user-patch checks.

Changes:

  • Adds the board’s /etc/portage/patches directory to the symlinks created in the image build’s Portage configuration root.
File Description
build_library/​build_image_util.sh Links user patches into the configuration root in start_image().

Review effort: Balanced

@chewi chewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with cherry-picking? 😝

@t-lo
t-lo merged commit f79d749 into main Nov 9, 2026
2 of 3 checks passed
@t-lo
t-lo deleted the t-lo/build_image-symlink-user-patches branch November 9, 2026 12:57

This branch is waiting to be deployed

1 waiting deployment
development — fd6b122a Waiting Nov 9, 2026 by t-lo via Wait for approval #6106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants