Repository navigation
build_image_util: symlink user patches into dest - #4372
Merged
Merged
Conversation
This change symlinks our user patches into the image install
destination. It fixes an issue with portage when installing binpkgs
which breaks the image build:
!!! The following binary packages have been ignored due to user patches:
net-misc/wget-1.25.0-r3 for /home/sdk/trunk/src/build/images/arm64-usr/developer-9999.0.6104+github-4348-a1/dev-image-rootfs/
...
!!! All binary packages that could satisfy "net-misc/wget" for /home/sdk/trunk/src/build/images/arm64-usr/developer-9999.0.6104+github-4348-a1/dev-image-rootfs/ have been masked.
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the change linking board user patches into the image build’s Portage configuration root.
No open issues 🎉
What changed in this PR
Makes board user patches available to Portage during image creation, addressing binary packages being rejected because of user-patch checks.
Changes:
- Adds the board’s
/etc/portage/patchesdirectory to the symlinks created in the image build’s Portage configuration root.
| File | Description |
|---|---|
build_library/build_image_util.sh |
Links user patches into the configuration root in start_image(). |
Review effort: Balanced
chewi
approved these changes
Nov 9, 2026
chewi
left a comment
Contributor
There was a problem hiding this comment.
What's wrong with cherry-picking? 😝
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change symlinks our user patches into the image install destination. It fixes an issue with portage when installing binpkgs which breaks the image build: