Skip to content

Update gentoo submodule to a1662c61dc98 - #4348

Merged
chewi merged 7 commits into
mainfrom
buildbot/update-gentoo-submodule
Nov 10, 2026
Merged

chewi merged 7 commits into
mainfrom
buildbot/update-gentoo-submodule

Conversation

@flatcar-infra

@flatcar-infra flatcar-infra commented Nov 1, 2026 •

Copy link
Copy Markdown

Update sdk_container/src/third_party/gentoo to flatcar-hub/gentoo@a1662c6.

@flatcar-infra flatcar-infra added auto-ci jenkins-ci Perform a CI build using Jenkins rather than GitHub Actions main labels Nov 1, 2026
@flatcar-infra
flatcar-infra requested a review from a team as a code owner November 1, 2026 04:03
@flatcar-infra
flatcar-infra force-pushed the buildbot/update-gentoo-submodule branch from 9d54beb to 013328d Compare November 2, 2026 04:03
@flatcar-infra flatcar-infra changed the title Update gentoo submodule to ce8854c24d63 Update gentoo submodule to fc2ce7274572 Nov 2, 2026
@t-lo

t-lo commented Nov 2, 2026

Copy link
Copy Markdown
Member
04:09:15   �[32m*�[0m Applying user patches from /etc/portage/patches ...
04:09:15   �[32m*�[0m Applying 0001-uniq-fix-read-overrun-with-w.patch ...
04:09:15  patching file src/uniq.c
04:09:15  Hunk #1 FAILED at 285.
04:09:15  1 out of 1 hunk FAILED -- saving rejects to file src/uniq.c.rej
04:09:15  �[A�[72C �[34;01m[ �[31;01m!!�[34;01m ]�[0m
04:09:15   �[31;01m*�[0m ERROR: sys-apps/coreutils-9.12::gentoo failed (prepare phase):
04:09:15   �[31;01m*�[0m   patch '-p1' '-f' '-g0' '--no-backup-if-mismatch' failed with '/etc/portage/patches/sys-apps/coreutils/0001-uniq-fix-read-overrun-with-w.patch'

Curious, applying a coreutils patch failed. Did upstream coreutils ingest it and Gentoo should stop carrying it?

@chewi

chewi commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Can't look yet, but yes, that's my guess.

@flatcar-infra flatcar-infra changed the title Update gentoo submodule to fc2ce7274572 Update gentoo submodule to b30d7c4928ee Nov 3, 2026
@flatcar-infra
flatcar-infra force-pushed the buildbot/update-gentoo-submodule branch 2 times, most recently from c40050d to 7057867 Compare November 4, 2026 04:03
@flatcar-infra flatcar-infra changed the title Update gentoo submodule to b30d7c4928ee Update gentoo submodule to 86dd140a5903 Nov 4, 2026
@chewi

chewi commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

I've checked now, 9.12 does include these changes. The patches need to be dropped.

@flatcar-infra
flatcar-infra force-pushed the buildbot/update-gentoo-submodule branch from 3803c33 to 08d7e67 Compare November 5, 2026 04:03
@flatcar-infra flatcar-infra changed the title Update gentoo submodule to 86dd140a5903 Update gentoo submodule to 9374e148b923 Nov 5, 2026
@flatcar-infra
flatcar-infra force-pushed the buildbot/update-gentoo-submodule branch from 08d7e67 to 27c2328 Compare November 5, 2026 16:36
@flatcar-infra flatcar-infra changed the title Update gentoo submodule to 9374e148b923 Update gentoo submodule to 16dc2778804d Nov 5, 2026
@t-lo

t-lo commented Nov 5, 2026

Copy link
Copy Markdown
Member

Fixed the issue in #4359 and kicked off another run.

@flatcar-infra
flatcar-infra force-pushed the buildbot/update-gentoo-submodule branch from 27c2328 to a5f1993 Compare November 6, 2026 15:46
@flatcar-infra flatcar-infra changed the title Update gentoo submodule to 16dc2778804d Update gentoo submodule to 232fc7d06685 Nov 6, 2026
@t-lo

t-lo commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

It's crun now:

17:40:08   �[32m*�[0m Applying 0001-cve-2026-88264.patch ...
17:40:08  patching file src/libcrun/linux.c
17:40:08  Hunk #1 succeeded at 4305 (offset 267 lines).
17:40:08  Hunk #2 FAILED at 4055.
17:40:08  1 out of 2 hunks FAILED -- saving rejects to file src/libcrun/linux.c.rej
17:40:08  patching file tests/test_devices.py
17:40:08  Hunk #1 succeeded at 474 with fuzz 1 (offset 75 lines).
17:40:08  Hunk #2 FAILED at 578.
17:40:08  1 out of 2 hunks FAILED -- saving rejects to file tests/test_devices.py.rej
17:40:08  �[A�[72C �[34;01m[ �[31;01m!!�[34;01m ]�[0m
17:40:08   �[31;01m*�[0m ERROR: app-containers/crun-1.30.1::gentoo failed (prepare phase):

PR/fix incoming.

@t-lo

t-lo commented Nov 6, 2026

Copy link
Copy Markdown
Member

Note to self: Never reference a comment in a PR in another PR with the term "fixes: " before that link. Caused this PR to be auto-closed 😱

@flatcar-infra
flatcar-infra force-pushed the buildbot/update-gentoo-submodule branch 2 times, most recently from b36e496 to 9f6984c Compare November 8, 2026 04:03
@flatcar-infra flatcar-infra changed the title Update gentoo submodule to 232fc7d06685 Update gentoo submodule to d63b2074ec80 Nov 8, 2026
@flatcar-infra
flatcar-infra force-pushed the buildbot/update-gentoo-submodule branch from 9f6984c to a9097b7 Compare November 9, 2026 04:03
@flatcar-infra flatcar-infra changed the title Update gentoo submodule to d63b2074ec80 Update gentoo submodule to be0f1a467160 Nov 9, 2026
@t-lo

t-lo commented Nov 9, 2026

Copy link
Copy Markdown
Member

Next issue is:

0:38:54  !!! The following binary packages have been ignored due to user patches:
10:38:54  
10:38:54       net-misc/wget-1.25.0-r3 for /home/sdk/trunk/src/build/images/arm64-usr/developer-9999.0.6104+github-4348-a1/dev-image-rootfs/
[...]
10:38:54  !!! All binary packages that could satisfy "net-misc/wget" for /home/sdk/trunk/src/build/images/arm64-usr/developer-9999.0.6104+github-4348-a1/dev-image-rootfs/ have been masked.

Addressed here: #4372

@flatcar-infra
flatcar-infra force-pushed the buildbot/update-gentoo-submodule branch from a9097b7 to 30aaa53 Compare November 9, 2026 12:57
@flatcar-infra flatcar-infra changed the title Update gentoo submodule to be0f1a467160 Update gentoo submodule to 297fdc68a405 Nov 9, 2026
@t-lo

t-lo commented Nov 9, 2026

Copy link
Copy Markdown
Member

The issue persists for binpackages that are shipped with the SDK, since these were built before the user-patches feature existed:

15:41:26  Dependency resolution took 0.45 s (backtrack: 0/20).
15:41:26  
15:41:26  
15:41:26  !!! The following binary packages have been ignored due to user patches:
15:41:26  
15:41:26       app-arch/bzip2-1.0.8-r5 for /home/sdk/trunk/src/build/images/arm64-usr/developer-9999.0.6107+github-4348-a1/dev-image-rootfs/
15:41:26  
15:41:26  !!! These user patches are triggering this warning:
15:41:26  
15:41:26      app-arch/bzip2/0001-bzip2recover-CVE-2026-42250.patch

Chewi is working on a fix.

@t-lo

t-lo commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Full list of affected packages:

  • app-arch/bzip2
  • sec-policy/selinux-base-policy
  • sec-policy/selinux-dbus
  • sys-libs/libsemanage
  • sec-policy/selinux-base
  • sec-policy/selinux-unconfined

Manually building the binpkgs resolves this issue.

Also,

  • dev-libs/openssl
    needs to be rebuilt to work around a fipsinstall issue.

@chewi Are you OK with merging this so we get an updated SDK?

@t-lo t-lo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as good as it gets, given the portage change. Built locally after manually emerging the packages that need a rebuild for the new portage flag; image build works.

Signed-off-by: Flatcar Buildbot <buildbot@flatcar-linux.org>
@flatcar-infra flatcar-infra changed the title Update gentoo submodule to 297fdc68a405 Update gentoo submodule to a1662c61dc98 Nov 10, 2026
@flatcar-infra
flatcar-infra force-pushed the buildbot/update-gentoo-submodule branch from 7893acc to 0dd4390 Compare November 10, 2026 04:03
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This workaround only applied when glibc was below EAPI 3.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>

@t-lo t-lo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both AMD64 and ARM64 package and image builds succeed. Some test failures need to be addressed; however, given the amount of updates we're ingesting that's not unexpected.

LGTM, let's merge so we can focus on fixing the test failures.

Portage has reliably done this for ROOT for a long time.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Portage has supported calling this via a CHOST-based wrapper for a very
long time, so just name our wrapper that instead. We don't need to
specify the -r option for the root directory because Portage does this
for us.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
sys-apps/baselayout is no longer the only shortcut case, so just move
this call to where it's needed.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This is currently necessary for just one case, openssl's pkg_preinst
where it does a fipsinstall.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
@chewi
chewi force-pushed the buildbot/update-gentoo-submodule branch from df9ba39 to d78e638 Compare November 10, 2026 15:26
@chewi
chewi merged commit f055db2 into main Nov 10, 2026
1 of 2 checks passed
@chewi
chewi deleted the buildbot/update-gentoo-submodule branch November 10, 2026 15:27

This branch was successfully deployed

No deployments
development — d78e6383 Deployed Nov 10, 2026 by chewi via Wait for approval #6115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-ci jenkins-ci Perform a CI build using Jenkins rather than GitHub Actions main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants