Skip to content

fix(evaluation): resolve PR gate failures (lint, CI extras, remove flyradar example) #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelgfierro merged 3 commits into from
Jun 19, 2026
Merged

fix(evaluation): resolve PR gate failures (lint, CI extras, remove flyradar example) #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1d28a5
remove examples/flyradar_eval_example.py
miguelgfierro Jun 19, 2026
6161718
ci: add --extra evaluation to typecheck and test sync steps
miguelgfierro Jun 19, 2026
203134c
fix(evaluation): resolve all ruff lint errors (import sort, SIM108, B…
miguelgfierro Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
- uses: actions/setup-python@v6
with:
python-version: '3.13'
- run: uv sync --extra dev --extra binary --extra vectorstores-sqlite-vec --extra openai-embeddings
- run: uv sync --extra dev --extra binary --extra vectorstores-sqlite-vec --extra openai-embeddings --extra evaluation
- run: uv run pyright

test:
Expand All @@ -72,7 +72,7 @@ jobs:
- uses: actions/setup-python@v6
with:
python-version: '3.13'
- run: uv sync --extra dev --extra binary --extra vectorstores-sqlite-vec --extra vectorstores-pgvector --extra openai-embeddings
- run: uv sync --extra dev --extra binary --extra vectorstores-sqlite-vec --extra vectorstores-pgvector --extra openai-embeddings --extra evaluation
- run: uv run pytest -m "not nightly" --cov --cov-report=term-missing

build:
Expand Down
13 changes: 3 additions & 10 deletions examples/flycanon_eval_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@
import sys
from pathlib import Path

from fireflyframework_agentic.evaluation import RetrieverMetrics, compute_retrieval_metrics

from fireflyframework_agentic.evaluation import RetrieverMetrics

# ---------------------------------------------------------------------------
# Helpers
Expand Down Expand Up @@ -171,10 +170,7 @@ def _print_metrics_table(metrics: RetrieverMetrics, baseline: dict | None) -> No
if value is None:
continue
# Format floats as 4 decimal places; ints as plain integers.
if isinstance(value, float):
cur_str = f"{value:.4f}"
else:
cur_str = str(value)
cur_str = f"{value:.4f}" if isinstance(value, float) else str(value)

row = f"{key:<{col_w}} {cur_str:>{num_w}}"
if baseline and key in baseline and isinstance(value, float):
Expand Down Expand Up @@ -353,10 +349,7 @@ def build_parser() -> argparse.ArgumentParser:
p.add_argument(
"--baseline",
default=None,
help=(
"Path to baseline.json (champion store). When absent, scores are printed "
"without comparison."
),
help=("Path to baseline.json (champion store). When absent, scores are printed without comparison."),
)
p.add_argument(
"--promote-if-better",
Expand Down
Loading