Skip to content

fix(evaluation): resolve PR gate failures (lint, CI extras, remove flyradar example)#280

Merged
miguelgfierro merged 3 commits into
feat/evaluation-frameworkfrom
fix/eval-ci-gate
Jun 19, 2026
Merged

fix(evaluation): resolve PR gate failures (lint, CI extras, remove flyradar example)#280
miguelgfierro merged 3 commits into
feat/evaluation-frameworkfrom
fix/eval-ci-gate

Conversation

@miguelgfierro

Copy link
Copy Markdown
Contributor

What failed

The PR gate for #279 failed on Lint, Type Check, Test, and Pre-commit.

Fixes

Remove flyradar example (per user instruction):

  • Deleted examples/flyradar_eval_example.py

CI: add --extra evaluation to sync steps:

  • typecheck job: uv sync now includes --extra evaluation
  • test job: uv sync now includes --extra evaluation
  • Without this, numpy is absent and all evaluation tests fail with ModuleNotFoundError

Ruff lint fixes across fireflyframework_agentic/evaluation/ and examples/:

  • I001 — sorted all unsorted import blocks (__init__.py, cli.py, matcher.py, judge.py, judge_client.py, scorecard.py, corpus.py, gates.py, run_config_snapshot.py)
  • F401 — removed unused compute_retrieval_metrics import in flycanon_eval_example.py
  • SIM108 — replaced if/else block with ternary in flycanon_eval_example.py
  • B905 — added strict=False to all bare zip() calls in judge.py
  • N806 — lowercased PER_SURFACE_CAP and BLEND_PHRASES function-local constants
  • UP035 — replaced from typing import Sequence with from collections.abc import Sequence in stats.py
  • SIM102 — collapsed nested if into single and in matcher.py

@miguelgfierro miguelgfierro merged commit ceaba78 into feat/evaluation-framework Jun 19, 2026
@miguelgfierro miguelgfierro deleted the fix/eval-ci-gate branch June 19, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant