Skip to content

fix(messaging, android): stop doing disk I/O on the main thread in the message broadcast receiver #18359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lyokone wants to merge 1 commit into
base: main
Choose a base branch
from
+49 −25
Open

fix(messaging, android): stop doing disk I/O on the main thread in the message broadcast receiver #18359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 49 additions & 25 deletions ...src/main/java/io/flutter/plugins/firebase/messaging/FlutterFirebaseMessagingReceiver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,19 @@
import android.util.Log;
import com.google.firebase.messaging.RemoteMessage;
import java.util.HashMap;
import java.util.concurrent.Executor;
import java.util.concurrent.Executors;

public class FlutterFirebaseMessagingReceiver extends BroadcastReceiver {
private static final String TAG = "FLTFireMsgReceiver";
static HashMap<String, RemoteMessage> notifications = new HashMap<>();

// SharedPreferences writes and process-state lookups must not run on the main
// thread: when a receiver returns, Android blocks the main thread until all
// pending SharedPreferences.apply() writes have hit disk (QueuedWork.waitToFinish),
// which causes ANRs under I/O pressure.
private static final Executor backgroundExecutor = Executors.newSingleThreadExecutor();

@Override
public void onReceive(Context context, Intent intent) {
Log.d(TAG, "broadcast received for message");
Expand All @@ -38,37 +46,53 @@ public void onReceive(Context context, Intent intent) {

RemoteMessage remoteMessage = new RemoteMessage(intent.getExtras());

// Store the RemoteMessage if the message contains a notification payload.
// Keep the in-memory message available to the plugin on the main thread; it is
// read from the main thread when a notification is tapped.
if (remoteMessage.getNotification() != null) {
notifications.put(remoteMessage.getMessageId(), remoteMessage);
FlutterFirebaseMessagingStore.getInstance().storeFirebaseMessage(remoteMessage);
}

// |-> ---------------------
// App in Foreground
// ------------------------
if (FlutterFirebaseMessagingUtils.isApplicationForeground(context)) {
FlutterFirebaseRemoteMessageLiveData.getInstance().postRemoteMessage(remoteMessage);
return;
}
// goAsync() keeps the broadcast alive until pendingResult.finish() so the
// remaining work can safely run off the main thread.
final PendingResult pendingResult = goAsync();
backgroundExecutor.execute(
() -> {
try {
// Store the RemoteMessage if the message contains a notification payload.
if (remoteMessage.getNotification() != null) {
FlutterFirebaseMessagingStore.getInstance().storeFirebaseMessage(remoteMessage);
}

// |-> ---------------------
// App in Foreground
// ------------------------
if (FlutterFirebaseMessagingUtils.isApplicationForeground(context)) {
FlutterFirebaseRemoteMessageLiveData.getInstance().postRemoteMessage(remoteMessage);
return;
}

// |-> ---------------------
// App in Background/Quit
// ------------------------
Intent onBackgroundMessageIntent =
new Intent(context, FlutterFirebaseMessagingBackgroundService.class);
// |-> ---------------------
// App in Background/Quit
// ------------------------
Intent onBackgroundMessageIntent =
new Intent(context, FlutterFirebaseMessagingBackgroundService.class);

Parcel parcel = Parcel.obtain();
remoteMessage.writeToParcel(parcel, 0);
// We write to parcel using RemoteMessage.writeToParcel() to pass entire RemoteMessage as array
// of bytes
// Which can be read using RemoteMessage.createFromParcel(parcel) API
onBackgroundMessageIntent.putExtra(
FlutterFirebaseMessagingUtils.EXTRA_REMOTE_MESSAGE, parcel.marshall());
Parcel parcel = Parcel.obtain();
remoteMessage.writeToParcel(parcel, 0);
// We write to parcel using RemoteMessage.writeToParcel() to pass entire RemoteMessage
// as array
// of bytes
// Which can be read using RemoteMessage.createFromParcel(parcel) API
onBackgroundMessageIntent.putExtra(
FlutterFirebaseMessagingUtils.EXTRA_REMOTE_MESSAGE, parcel.marshall());

FlutterFirebaseMessagingBackgroundService.enqueueMessageProcessing(
context,
onBackgroundMessageIntent,
remoteMessage.getOriginalPriority() == RemoteMessage.PRIORITY_HIGH);
FlutterFirebaseMessagingBackgroundService.enqueueMessageProcessing(
context,
onBackgroundMessageIntent,
remoteMessage.getOriginalPriority() == RemoteMessage.PRIORITY_HIGH);
} finally {
pendingResult.finish();
}
});
}
}
Loading