Skip to content

fix(messaging, android): stop doing disk I/O on the main thread in the message broadcast receiver#18359

Open
Lyokone wants to merge 1 commit into
mainfrom
fix/12832
Open

fix(messaging, android): stop doing disk I/O on the main thread in the message broadcast receiver#18359
Lyokone wants to merge 1 commit into
mainfrom
fix/12832

Conversation

@Lyokone

@Lyokone Lyokone commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

FlutterFirebaseMessagingReceiver.onReceive() runs on the main thread and wrote every notification message to SharedPreferences; when a broadcast receiver finishes, Android blocks the main thread until pending SharedPreferences writes are flushed to disk (QueuedWork.waitToFinish), causing ANRs under I/O pressure. The receiver now hands the store write and message dispatch to a background executor via goAsync(), so no disk I/O or binder calls happen on the main thread; the in-memory notification map update stays on the main thread, where it is read.

Verified on an Android emulator with synthetic FCM broadcasts (adb root + am broadcast to the receiver): foreground delivery to onMessage, background delivery via FlutterFirebaseMessagingBackgroundService, and message persistence to the store all behave identically before and after the change, and the firebase_messaging e2e suite passes. The ANR itself is a timing condition that cannot be asserted by the existing test infrastructure (no native Android unit tests in the repo, and an FCM push cannot be triggered from the Dart integration tests).

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide). (Not testable with current infra: ANRs are timing conditions and the repo has no native Android unit tests; behavior parity was verified manually on an emulator — see description.)
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…ving multiple notifications at the same time
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_messaing]: android.os.MessageQueue.nativePollOnce (Native method)

3 participants