Repository navigation
feat(proxy): forward ranges on internal metrics and pass review accounts through - #194
Merged
Merged
Conversation
…nts through Refs fells-code/seamless-auth-api#132 and #331.
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapter side of fells-code/seamless-auth-api#364 (#132) and fells-code/seamless-auth-api#365 (#331).
Ranged internal metrics (#132)
getDashboardMetricsHandlerandgetSecurityAnomaliesHandlertookBaseOptswith no query, so the range and paging the API now accepts on/internal/metrics/dashboardand/internal/security/anomalieswould never have reached it. The adapter would have answered 200 for the default window, which is exactly the silent failure the query-forwarding tests exist for. Both handlers now takeWithQuery, and Express, Fastify and Next.js pass the request's query.Tests:
Review accounts (#331)
GET /admin/review-accountsis passed through on the caller's access identity, with itsdaysquery. It returns whether review accounts are enabled, the configured addresses, whether a valid code is set (never the code itself) and recent sign-in counts. It is in the Express router, the Fastify and Next.js proxy tables, and theensureCookiesmap, with query-forwarding rows and parity cases.Checks
pnpm buildandpnpm test(core 322, express 195, nextjs 131, fastify 118, all passing). The changed files are Prettier-clean.Note: once
@seamless-auth/types0.28.0 publishes,check:types-currentwill ask for a bump here as well. Nothing in this PR needs the new types, so the bump can ride along with it or follow it.