Repository navigation
feat: follow the range on headline metrics and anomalies; warn on review accounts - #285
Merged
Merged
Conversation
…iew accounts Overview's tiles and Security's anomaly feed now take the selected range, labelling each figure by the window it shows. Overview warns while store review accounts are enabled. Refs fells-code/seamless-auth-api#132 and #331. Closes #148.
Bccorb
marked this pull request as ready for review
October 7, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
@seamless-auth/types0.28.0 (fells-code/seamless-auth-types#91), now published and pinned here (check:types-currentpasses).Depends on fells-code/seamless-auth-api#364 (#132), fells-code/seamless-auth-api#365 (#331) and fells-code/seamless-auth-server#194.
Ranged headline metrics and anomalies (finishes #148)
useDashboardanduseAnomaliestake{ from, to }, and Overview and Security pass the same bounds the charts already use. Both keep the range in the URL as before.dashboardFigureshelper picks the window-neutral fields (loginSuccess,successRate, ...) when the API echoes awindow, and the*24hfields otherwise. Every label is driven by which one was used:So a tile never claims to follow the selector while showing a fixed window. Date range on the data screens (export delivered) #148 required exactly that.
total(now every match in the window) for "Showing X of Y reported signals".Review accounts notice (#331)
useReviewAccountsreadsGET /admin/review-accounts, with no retries.ReviewAccountsNotice, at the top of Overview, shows a warning only whileenabled. It lists the addresses, sign-ins with the fixed code in the last 30 days (and the most recent), wrong codes entered, and the instruction to clearREVIEW_ACCOUNT_EMAILS. The code itself is never part of the response.Checks
npm run typecheck,npm run lint,npm run format:check,npm run buildnpm run coverage: 89 files, 580 tests passnpm run test:e2e: 149 pass, including new specs for the range reaching/internal/metrics/dashboardand the tiles relabelling, and for the review notice. The e2e seed registers a disabled/admin/review-accountsby default, since Overview now calls it.