Repository navigation
feat(ui): Add ZIP import for custom emojis #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nove-b
wants to merge
1
commit into
fedify-dev:main
Choose a base branch
from
nove-b:feature/emoji-zip-import
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| links: | ||
| '#686': https://github.com/fedify-dev/hollo/issues/686 | ||
| '#688': https://github.com/fedify-dev/hollo/pull/688 | ||
| --- | ||
| - Added support for importing custom emojis from Misskey packed emoji ZIP | ||
| archives in the administration dashboard. Configure either | ||
| `EMOJI_IMPORT_FS_PATH` or `S3_EMOJI_IMPORT_BUCKET` to enable temporary | ||
| archive storage. The import limits default to 50 MiB | ||
| (`EMOJI_IMPORT_MAX_ARCHIVE_BYTES`), 1,000 entries | ||
| (`EMOJI_IMPORT_MAX_ENTRY_COUNT`), and 250 MiB extracted | ||
| (`EMOJI_IMPORT_MAX_EXTRACTED_BYTES`). [[#686], [#688] by nove-b] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
drizzle/20261028021042_custom-emoji-import-jobs/migration.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| CREATE TYPE "import_custom_emoji_status_enum" AS ENUM('pending', 'processing', 'completed', 'failed');--> statement-breakpoint | ||
| CREATE TABLE "custom_emoji_import_jobs" ( | ||
| "id" uuid PRIMARY KEY, | ||
| "archive_key" text NOT NULL, | ||
| "status" "import_custom_emoji_status_enum" DEFAULT 'pending'::"import_custom_emoji_status_enum" NOT NULL, | ||
| "imported_count" integer DEFAULT 0 NOT NULL, | ||
| "skipped_count" integer DEFAULT 0 NOT NULL, | ||
| "failed_count" integer DEFAULT 0 NOT NULL, | ||
| "error" text, | ||
| "created" timestamp with time zone DEFAULT CURRENT_TIMESTAMP NOT NULL, | ||
| "completed" timestamp with time zone | ||
| ); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section documents the variables but not the condition that enables the feature. Add a sentence that the ZIP import page returns
503 Service UnavailableunlessEMOJI_IMPORT_FS_PATHorS3_EMOJI_IMPORT_BUCKETis set.